Re: patch: remove is_gimple_non_addressable

2012-01-09 Thread Richard Guenther
On Mon, Jan 9, 2012 at 3:57 PM, Aldy Hernandez wrote: > >> Ok with simply excluding SSA_NAMEs like >> >> @@ -4411,16 +4411,27 @@ gimplify_modify_expr_rhs (tree *expr_p, >>                /* It's OK to use the target directly if it's being >>                   initialized. */ >>                use_

Re: patch: remove is_gimple_non_addressable

2012-01-09 Thread Aldy Hernandez
Ok with simply excluding SSA_NAMEs like @@ -4411,16 +4411,27 @@ gimplify_modify_expr_rhs (tree *expr_p, /* It's OK to use the target directly if it's being initialized. */ use_target = true; - else if (TREE_CODE (*to_p) != SSA_NAME

Re: patch: remove is_gimple_non_addressable

2012-01-09 Thread Richard Guenther
On Fri, Jan 6, 2012 at 6:05 PM, Aldy Hernandez wrote: > On 01/05/12 09:36, Richard Guenther wrote: >> >> On Thu, Jan 5, 2012 at 3:48 PM, Aldy Hernandez  wrote: >>> >>> As you suggested here: >>> >>> http://gcc.gnu.org/ml/gcc-patches/2012-01/msg00232.html >>> >>> Bootregged on x86-64 Linux. >>> >>>

Re: patch: remove is_gimple_non_addressable

2012-01-06 Thread Aldy Hernandez
On 01/05/12 09:36, Richard Guenther wrote: On Thu, Jan 5, 2012 at 3:48 PM, Aldy Hernandez wrote: As you suggested here: http://gcc.gnu.org/ml/gcc-patches/2012-01/msg00232.html Bootregged on x86-64 Linux. OK? No, this pessimizes things too much at gimplification time, please simply inline t

Re: patch: remove is_gimple_non_addressable

2012-01-05 Thread Richard Guenther
On Thu, Jan 5, 2012 at 3:48 PM, Aldy Hernandez wrote: > As you suggested here: > > http://gcc.gnu.org/ml/gcc-patches/2012-01/msg00232.html > > Bootregged on x86-64 Linux. > > OK? No, this pessimizes things too much at gimplification time, please simply inline the predicate instead. Richard.