Re: opt-info message change for vectorizer

2013-08-29 Thread Richard Biener
On Wed, Aug 28, 2013 at 8:14 PM, Xinliang David Li wrote: > Fixed as requested. I don't like the extra newline either, but I will > leave that to Teresa. > > basic3.c:8:foo: note: loop vectorized > > basic3.c:8:foo: note: loop versioned for vectorization because of > possible aliasing > > basic3.c

Re: opt-info message change for vectorizer

2013-08-28 Thread Xinliang David Li
Fixed as requested. I don't like the extra newline either, but I will leave that to Teresa. basic3.c:8:foo: note: loop vectorized basic3.c:8:foo: note: loop versioned for vectorization because of possible aliasing basic3.c:8:foo: note: loop peeled for vectorization to enhance alignment basic3.c

Re: opt-info message change for vectorizer

2013-08-28 Thread Teresa Johnson
On Wed, Aug 28, 2013 at 2:45 AM, Richard Biener wrote: > On Tue, Aug 27, 2013 at 10:30 PM, Xinliang David Li > wrote: >> If this is the convention, we should probably have another patch to >> fix all the existing opt-info messages. > > Yes please. > > Also ... > > > b.c:16:A::foo: note: Loop

Re: opt-info message change for vectorizer

2013-08-28 Thread Richard Biener
On Tue, Aug 27, 2013 at 10:30 PM, Xinliang David Li wrote: > If this is the convention, we should probably have another patch to > fix all the existing opt-info messages. Yes please. Also ... b.c:16:A::foo: note: Loop is vectorized "loop vectorized" b.c:16:A::foo: note: Loop i

Re: opt-info message change for vectorizer

2013-08-27 Thread Xinliang David Li
If this is the convention, we should probably have another patch to fix all the existing opt-info messages. thanks, David On Tue, Aug 27, 2013 at 1:23 PM, Mike Stump wrote: > On Aug 27, 2013, at 11:22 AM, Xinliang David Li wrote: >> Does this one look ok? > > We don't capitalize text after err

Re: opt-info message change for vectorizer

2013-08-27 Thread Mike Stump
On Aug 27, 2013, at 11:22 AM, Xinliang David Li wrote: > Does this one look ok? We don't capitalize text after error:, warning: or note:. > thanks, > > David > > On Thu, Aug 22, 2013 at 4:20 PM, Xinliang David Li wrote: >> Hi, In this patch, loop alignment peeling and loop versioning >> trans

Re: opt-info message change for vectorizer

2013-08-27 Thread Xinliang David Li
yes -- the long unmangled names can be annoying -- that is why I chose to dump the short form of the function names -- combined with line numbers, it should be enough to get the full context. David On Tue, Aug 27, 2013 at 11:36 AM, Teresa Johnson wrote: > My only concern is whether the dump mess

Re: opt-info message change for vectorizer

2013-08-27 Thread Teresa Johnson
My only concern is whether the dump messages will get too long with the full function name on the same line. The infrastructure that emits inform() notes ensures that the function name is printed before each block of messages related to that function (via an "In function foo:" type message), but I

Re: opt-info message change for vectorizer

2013-08-27 Thread Xinliang David Li
Does this one look ok? thanks, David On Thu, Aug 22, 2013 at 4:20 PM, Xinliang David Li wrote: > Hi, In this patch, loop alignment peeling and loop versioning > transformation will be reported via -fopt-info by default. This will > help vectorizer size tuning. > > It also enhances the opt-info