Re: new option -Wno-maybe-uninitialized

2011-04-25 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/21/11 11:43, Xinliang David Li wrote: > > There are three different kind of uninit warnings: > > 1) definitely uninitialized, and the use the variable dominates the > exit -- this is the must be used uninitialized case > 2) definitely uninitia

Re: new option -Wno-maybe-uninitialized

2011-04-22 Thread Xinliang David Li
Looks like we won't get consensus (as Jeff mentioned) on the naming etc. Shall I just commit this one? Thanks, David On Fri, Apr 22, 2011 at 9:23 AM, Gabriel Dos Reis wrote: > On Fri, Apr 22, 2011 at 3:52 AM, Richard Guenther > wrote: > > >>> Maybe-uninitialized matches case 3) -- different fr

Re: new option -Wno-maybe-uninitialized

2011-04-22 Thread Gabriel Dos Reis
On Fri, Apr 22, 2011 at 3:52 AM, Richard Guenther wrote: >> Maybe-uninitialized matches case 3) -- different from case 2 which is >> actually 'maybe-used-uninitialized'. > > Other diagnostics use a level to indicate their noise level.  So, why not > do something like -Wuninitialized=N, with N fr

Re: new option -Wno-maybe-uninitialized

2011-04-22 Thread Xinliang David Li
Sounds like a good idea, but does -Werror=xxx work for this ? I tried cases with -Wstrict-aliasing, -Werror handling seems broken. Thanks, David On Fri, Apr 22, 2011 at 1:52 AM, Richard Guenther wrote: > On Thu, Apr 21, 2011 at 7:43 PM, Xinliang David Li wrote: >> On Thu, Apr 21, 2011 at 10:2

Re: new option -Wno-maybe-uninitialized

2011-04-22 Thread Richard Guenther
On Thu, Apr 21, 2011 at 7:43 PM, Xinliang David Li wrote: > On Thu, Apr 21, 2011 at 10:21 AM, Jeff Law wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 04/07/11 18:24, Xinliang David Li wrote: >>> Hi, >>> >>> the following patch implements the option to fine control the emitted

Re: new option -Wno-maybe-uninitialized

2011-04-21 Thread Xinliang David Li
On Thu, Apr 21, 2011 at 10:21 AM, Jeff Law wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 04/07/11 18:24, Xinliang David Li wrote: >> Hi, >> >> the following patch implements the option to fine control the emitted >> warnings -- >> 1) allow suppressing warnings for use of values t

Re: new option -Wno-maybe-uninitialized

2011-04-21 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/07/11 18:24, Xinliang David Li wrote: > Hi, > > the following patch implements the option to fine control the emitted > warnings -- > 1) allow suppressing warnings for use of values that may be > uninitialized. Definitely uninitialized values t