Re: [PATCH v3] Re: libstdc++: use is_virtual_base_of in std::weak_ptr operations

2024-12-09 Thread Giuseppe D'Angelo
Hello, On 04/12/2024 13:20, Giuseppe D'Angelo wrote: Thank you for the review! I think I've incorporated all the changes, new patch is attached. Some other comments... By doing some more testing, I've noticed that this patch causes a build issue when a weak_ptr is used to construct a weak_pt

Re: [PATCH v2] Re: libstdc++: use is_virtual_base_of in std::weak_ptr operations

2024-12-04 Thread Jonathan Wakely
On Wed, 4 Dec 2024 at 12:20, Giuseppe D'Angelo wrote: > > On 03/12/2024 18:02, Jonathan Wakely wrote: > > On Tue, 3 Dec 2024 at 16:56, Jonathan Wakely wrote: > >> > >> On Tue, 3 Dec 2024 at 16:19, Giuseppe D'Angelo > >> wrote: > >>> > >>> Hello, > >>> > >>> The attached patch changes std::weak_p

[PATCH v2] Re: libstdc++: use is_virtual_base_of in std::weak_ptr operations

2024-12-04 Thread Giuseppe D'Angelo
On 03/12/2024 18:02, Jonathan Wakely wrote: On Tue, 3 Dec 2024 at 16:56, Jonathan Wakely wrote: On Tue, 3 Dec 2024 at 16:19, Giuseppe D'Angelo wrote: Hello, The attached patch changes std::weak_ptr "converting move constructor/assignment" -- that is, from a rvalue weak_ptr to a weak_ptr.

Re: libstdc++: use is_virtual_base_of in std::weak_ptr operations

2024-12-03 Thread Jonathan Wakely
On Tue, 3 Dec 2024 at 16:56, Jonathan Wakely wrote: > > On Tue, 3 Dec 2024 at 16:19, Giuseppe D'Angelo > wrote: > > > > Hello, > > > > The attached patch changes std::weak_ptr "converting move > > constructor/assignment" -- that is, from a rvalue weak_ptr to a > > weak_ptr. > > > > In the general

Re: libstdc++: use is_virtual_base_of in std::weak_ptr operations

2024-12-03 Thread Jonathan Wakely
On Tue, 3 Dec 2024 at 16:19, Giuseppe D'Angelo wrote: > > Hello, > > The attached patch changes std::weak_ptr "converting move > constructor/assignment" -- that is, from a rvalue weak_ptr to a > weak_ptr. > > In the general case, such conversion requires lock()ing the weak_ptr > because the pointe