Re: libgomp: with USM, init 'link' variables with host address

2024-09-24 Thread Tobias Burnus
Now committed as r15-3836-g4cb20dc043cf70 Contrary to the originally posted patch, it also acts on the newer/newly added 'omp requires self_maps'. In the area of (unified-)shared memory/self maps, the next step seems to be to do still mapping for static variables – before moving to refinemen

Re: libgomp: with USM, init 'link' variables with host address

2024-09-17 Thread Tobias Burnus
Hi Thomas, short version: I think the patch as posted is fine and no action beyond is needed for this one issue. See below for the long version. Possibly modifications (now or as follow up): - using memcpy + or let the plugin do it - not adding link variables to the splay tree with 'USM'. Th

Re: libgomp: with USM, init 'link' variables with host address

2024-09-17 Thread Thomas Schwinge
Hi Tobias! On 2024-09-15T00:32:21+0200, Tobias Burnus wrote: > The idea of link variables is to replace he full device variable by a > pointer, permitting to map only parts of the variable to the device, > saving memory. > > However, having a pointer permits for (unified) shared memory to point