Re: libgo patch committed: Run examples

2019-02-28 Thread Ian Lance Taylor
On Thu, Feb 28, 2019 at 1:59 AM Rainer Orth wrote: > > > On Thu, Feb 21, 2019 at 1:47 AM Andreas Schwab wrote: > >> > >> On Feb 20 2019, Ian Lance Taylor wrote: > >> > >> > if test x$hasoutput = xtrue; then > >> > - echo ' {"'$n'", '$j', "'"$output"'", > >> >

Re: libgo patch committed: Run examples

2019-02-28 Thread Rainer Orth
Hi Ian, > On Thu, Feb 21, 2019 at 1:47 AM Andreas Schwab wrote: >> >> On Feb 20 2019, Ian Lance Taylor wrote: >> >> > if test x$hasoutput = xtrue; then >> > - echo ' {"'$n'", '$j', "'"$output"'", '$unordered'},' >> > + echo ' {"'$n'", '$j', "'"$(cat example2.tx

Re: libgo patch committed: Run examples

2019-02-27 Thread Ian Lance Taylor
On Thu, Feb 21, 2019 at 1:47 AM Andreas Schwab wrote: > > On Feb 20 2019, Ian Lance Taylor wrote: > > > if test x$hasoutput = xtrue; then > > - echo ' {"'$n'", '$j', "'"$output"'", '$unordered'},' > > + echo ' {"'$n'", '$j', "'"$(cat example

Re: libgo patch committed: Run examples

2019-02-21 Thread Andreas Schwab
On Feb 20 2019, Ian Lance Taylor wrote: > if test x$hasoutput = xtrue; then > - echo ' {"'$n'", '$j', "'"$output"'", '$unordered'},' > + echo ' {"'$n'", '$j', "'"$(cat example2.txt)"'", > '$unordered'},' That still has a problematic echo w

Re: libgo patch committed: Run examples

2019-02-20 Thread Ian Lance Taylor
On Mon, Feb 18, 2019 at 2:53 AM Rainer Orth wrote: > > > On Feb 18 2019, Rainer Orth wrote: > > > >> diff --git a/libgo/testsuite/gotest b/libgo/testsuite/gotest > >> --- a/libgo/testsuite/gotest > >> +++ b/libgo/testsuite/gotest > >> @@ -627,13 +627,13 @@ symtogo() { > >>

Re: libgo patch committed: Run examples

2019-02-18 Thread Rainer Orth
Hi Andreas, > On Feb 18 2019, Rainer Orth wrote: > >> diff --git a/libgo/testsuite/gotest b/libgo/testsuite/gotest >> --- a/libgo/testsuite/gotest >> +++ b/libgo/testsuite/gotest >> @@ -627,13 +627,13 @@ symtogo() { >> -e 's/[]*$/\\n/g' | >>

Re: libgo patch committed: Run examples

2019-02-18 Thread Andreas Schwab
On Feb 18 2019, Rainer Orth wrote: > diff --git a/libgo/testsuite/gotest b/libgo/testsuite/gotest > --- a/libgo/testsuite/gotest > +++ b/libgo/testsuite/gotest > @@ -627,13 +627,13 @@ symtogo() { >-e 's/[]*$/\\n/g' | >tr -d '

Re: libgo patch committed: Run examples

2019-02-18 Thread Rainer Orth
Hi Ian, > This patch to the libgo gotest script runs examples when appropriate > in the libgo testsuite. An example with a "// Output:" comment is > supposed to be run, comparing the output of the example with the text > in the comment. Up until now we were not actually doing that, so we > were