Re: libgo patch committed: Fix Makefile bug setting LD_LIBRARY_PATH

2017-11-22 Thread Eric Botcazou
> If we don't then i would say that's the bug to fix, not warp back in > time 20 years. Why let solaris hold hostage everybody else? Let's not start a flame war, please. Almost all other uses of grep in the libgo directory have >/dev/null instead of -q and nobody chokes on them. -- Eric Botcaz

Re: libgo patch committed: Fix Makefile bug setting LD_LIBRARY_PATH

2017-11-22 Thread Bernhard Reutner-Fischer
On 22 November 2017 at 09:07, Eric Botcazou wrote: >> grep -q was even required by SUSv2 from 1997 so Solaris should really >> support it. What version if Solaris is that and what version of grep? > > /usr/bin/grep on Solaris 10 (/usr/xpg4/bin/grep does support it). Why would we want to use /usr/

Re: libgo patch committed: Fix Makefile bug setting LD_LIBRARY_PATH

2017-11-22 Thread Eric Botcazou
> grep -q was even required by SUSv2 from 1997 so Solaris should really > support it. What version if Solaris is that and what version of grep? /usr/bin/grep on Solaris 10 (/usr/xpg4/bin/grep does support it). -- Eric Botcazou

Re: libgo patch committed: Fix Makefile bug setting LD_LIBRARY_PATH

2017-11-22 Thread Bernhard Reutner-Fischer
On 21 November 2017 20:53:50 CET, Eric Botcazou wrote: >> This patch by Than McIntosh fixes a small bug in the libgo Makefile >> recipe that constructs the directory from which to pick up >> libgcc_s.so; the gccgo invocation with -print-libgcc-file-name was >> missing the flags, which meant that f

Re: libgo patch committed: Fix Makefile bug setting LD_LIBRARY_PATH

2017-11-21 Thread Ian Lance Taylor
On Tue, Nov 21, 2017 at 11:53 AM, Eric Botcazou wrote: >> This patch by Than McIntosh fixes a small bug in the libgo Makefile >> recipe that constructs the directory from which to pick up >> libgcc_s.so; the gccgo invocation with -print-libgcc-file-name was >> missing the flags, which meant that f

Re: libgo patch committed: Fix Makefile bug setting LD_LIBRARY_PATH

2017-11-21 Thread Eric Botcazou
> This patch by Than McIntosh fixes a small bug in the libgo Makefile > recipe that constructs the directory from which to pick up > libgcc_s.so; the gccgo invocation with -print-libgcc-file-name was > missing the flags, which meant that for -m32 builds we'd see the > 64-bit libgcc dir. Bootstrapp