Re: fix for pr47837

2011-05-21 Thread Eric Botcazou
> 2011-03-08 Xinliang David Li > > PR c/47837 > * tree-ssa-uninit.c (pred_chain_length_cmp): New function. > (normalize_preds): New function. > (is_use_properly_guarded): Normalize def predicates. This broke the Ada compiler on some platforms, see PR tree-opt/48988. --

Re: fix for pr47837

2011-03-14 Thread Richard Guenther
On Mon, Mar 14, 2011 at 5:33 PM, Xinliang David Li wrote: > On Mon, Mar 14, 2011 at 6:16 AM, Diego Novillo wrote: >> On Fri, Mar 11, 2011 at 14:32, Jeff Law wrote: >> Regarding this particular patch, I hope it can be checked in to make the test clean. It is a simple enhancement to a wh

Re: fix for pr47837

2011-03-14 Thread Xinliang David Li
On Mon, Mar 14, 2011 at 6:16 AM, Diego Novillo wrote: > On Fri, Mar 11, 2011 at 14:32, Jeff Law wrote: > >>> Regarding this particular patch, I hope it can be checked in to make >>> the test clean. It is a simple enhancement to a wheel that is already >>> there. It also serves as a case that can

Re: fix for pr47837

2011-03-14 Thread Diego Novillo
On Fri, Mar 11, 2011 at 14:32, Jeff Law wrote: >> Regarding this particular patch, I hope it can be checked in to make >> the test clean. It is a simple enhancement to a wheel that is already >> there. It also serves as a case that can be referenced in the future >> when the more general mechanis

Re: fix for pr47837

2011-03-14 Thread Richard Guenther
On Sat, Mar 12, 2011 at 1:44 AM, Xinliang David Li wrote: > On Fri, Mar 11, 2011 at 11:50 AM, Jeff Law wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 03/09/11 09:24, Xinliang David Li wrote: >>> On Wed, Mar 9, 2011 at 6:03 AM, Jeff Law wrote: >>> On 03/09/11 02:45, Richard G

Re: fix for pr47837

2011-03-14 Thread Jakub Jelinek
On Tue, Mar 08, 2011 at 09:54:42AM -0800, Xinliang David Li wrote: > Please review the attached patch, it does some simplification of the > complicated logical or expressions (x1 or x2 or x3 ...) constructed > from control flow analysis into simpler form. BTW, PR47679 is another case of predicates

Re: fix for pr47837

2011-03-11 Thread Xinliang David Li
On Fri, Mar 11, 2011 at 11:50 AM, Jeff Law wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 03/09/11 09:24, Xinliang David Li wrote: >> On Wed, Mar 9, 2011 at 6:03 AM, Jeff Law wrote: >> On 03/09/11 02:45, Richard Guenther wrote: > On Tue, Mar 8, 2011 at 11:04 PM, Jeff Law wro

Re: fix for pr47837

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 8:50 PM, Jeff Law wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 03/09/11 09:24, Xinliang David Li wrote: >> On Wed, Mar 9, 2011 at 6:03 AM, Jeff Law wrote: >> On 03/09/11 02:45, Richard Guenther wrote: > On Tue, Mar 8, 2011 at 11:04 PM, Jeff Law wrot

Re: fix for pr47837

2011-03-11 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/09/11 09:24, Xinliang David Li wrote: > On Wed, Mar 9, 2011 at 6:03 AM, Jeff Law wrote: > On 03/09/11 02:45, Richard Guenther wrote: On Tue, Mar 8, 2011 at 11:04 PM, Jeff Law wrote: > True. I've been repeatedly thinking of building

Re: fix for pr47837

2011-03-11 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/09/11 11:07, Xinliang David Li wrote: > Ok. > > Regarding this particular patch, I hope it can be checked in to make > the test clean. It is a simple enhancement to a wheel that is already > there. It also serves as a case that can be referenced

Re: fix for pr47837

2011-03-09 Thread Xinliang David Li
Ok. Regarding this particular patch, I hope it can be checked in to make the test clean. It is a simple enhancement to a wheel that is already there. It also serves as a case that can be referenced in the future when the more general mechanism is available. Thanks, David On Wed, Mar 9, 2011 at

Re: fix for pr47837

2011-03-09 Thread Richard Guenther
On Wed, Mar 9, 2011 at 6:34 PM, Xinliang David Li wrote: > On Wed, Mar 9, 2011 at 8:29 AM, Richard Guenther > wrote: >> On Wed, Mar 9, 2011 at 5:24 PM, Xinliang David Li wrote: >>> On Wed, Mar 9, 2011 at 6:03 AM, Jeff Law wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1

Re: fix for pr47837

2011-03-09 Thread Xinliang David Li
On Wed, Mar 9, 2011 at 8:29 AM, Richard Guenther wrote: > On Wed, Mar 9, 2011 at 5:24 PM, Xinliang David Li wrote: >> On Wed, Mar 9, 2011 at 6:03 AM, Jeff Law wrote: >>> -BEGIN PGP SIGNED MESSAGE- >>> Hash: SHA1 >>> >>> On 03/09/11 02:45, Richard Guenther wrote: On Tue, Mar 8, 2011

Re: fix for pr47837

2011-03-09 Thread Xinliang David Li
On Wed, Mar 9, 2011 at 6:03 AM, Jeff Law wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 03/09/11 02:45, Richard Guenther wrote: >> On Tue, Mar 8, 2011 at 11:04 PM, Jeff Law wrote: > >> True.  I've been repeatedly thinking of building some on-the-side CFG >> with value-numbered pr

Re: fix for pr47837

2011-03-09 Thread Richard Guenther
On Wed, Mar 9, 2011 at 5:24 PM, Xinliang David Li wrote: > On Wed, Mar 9, 2011 at 6:03 AM, Jeff Law wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 03/09/11 02:45, Richard Guenther wrote: >>> On Tue, Mar 8, 2011 at 11:04 PM, Jeff Law wrote: >> >>> True.  I've been repeatedly

Re: fix for pr47837

2011-03-09 Thread Xinliang David Li
Sounds interesting. Do you have examples to illustrate your idea? Thanks, David On Wed, Mar 9, 2011 at 1:45 AM, Richard Guenther wrote: > On Tue, Mar 8, 2011 at 11:04 PM, Jeff Law wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 03/08/11 11:55, Diego Novillo wrote: >>> On 03

Re: fix for pr47837

2011-03-09 Thread Richard Guenther
On Wed, Mar 9, 2011 at 3:03 PM, Jeff Law wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 03/09/11 02:45, Richard Guenther wrote: >> On Tue, Mar 8, 2011 at 11:04 PM, Jeff Law wrote: > >> True.  I've been repeatedly thinking of building some on-the-side CFG >> with value-numbered pr

Re: fix for pr47837

2011-03-09 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/09/11 02:45, Richard Guenther wrote: > On Tue, Mar 8, 2011 at 11:04 PM, Jeff Law wrote: > True. I've been repeatedly thinking of building some on-the-side CFG > with value-numbered predicates to also catch the CFG vs. scalar-code > predicate c

Re: fix for pr47837

2011-03-09 Thread Richard Guenther
On Tue, Mar 8, 2011 at 11:04 PM, Jeff Law wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 03/08/11 11:55, Diego Novillo wrote: >> On 03/08/2011 12:54 PM, Xinliang David Li wrote: >>> Please review the attached patch, it does some simplification of the >>> complicated logical or exp

Re: fix for pr47837

2011-03-08 Thread Xinliang David Li
On Tue, Mar 8, 2011 at 2:04 PM, Jeff Law wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 03/08/11 11:55, Diego Novillo wrote: >> On 03/08/2011 12:54 PM, Xinliang David Li wrote: >>> Please review the attached patch, it does some simplification of the >>> complicated logical or expr

Re: fix for pr47837

2011-03-08 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/08/11 11:55, Diego Novillo wrote: > On 03/08/2011 12:54 PM, Xinliang David Li wrote: >> Please review the attached patch, it does some simplification of the >> complicated logical or expressions (x1 or x2 or x3 ...) constructed >> from control fl

Re: fix for pr47837

2011-03-08 Thread Xinliang David Li
On Tue, Mar 8, 2011 at 10:55 AM, Diego Novillo wrote: > On 03/08/2011 12:54 PM, Xinliang David Li wrote: >> >> Please review the attached patch, it does some simplification of the >> complicated logical or expressions (x1 or x2 or x3 ...) constructed >> from control flow analysis into simpler form

Re: fix for pr47837

2011-03-08 Thread Diego Novillo
On 03/08/2011 12:54 PM, Xinliang David Li wrote: Please review the attached patch, it does some simplification of the complicated logical or expressions (x1 or x2 or x3 ...) constructed from control flow analysis into simpler form. Bootstraps and works on s390x for both testcases. Bootstraps on

Re: fix for pr47837

2011-03-08 Thread Diego Novillo
On Tue, Mar 8, 2011 at 12:54, Xinliang David Li wrote: > Bootstraps on x86-64. Regression testing is on going (it takes forever > (whole night already) to finish possibly because the lto test in > c-torture ..). I don't think so. We have been having weird kernel problems in our machines when ru

Re: fix for pr47837

2011-03-08 Thread Xinliang David Li
On Tue, Mar 8, 2011 at 9:54 AM, Xinliang David Li wrote: > Please review the attached patch, it does some simplification of the > complicated logical or expressions (x1 or x2 or x3 ...) constructed > from control flow analysis into simpler form. > > Bootstraps and works on s390x for both testcases