Re: add dbgcnt and opt-info support for devirtualization

2014-05-20 Thread Xinliang David Li
On Tue, May 20, 2014 at 4:32 AM, Richard Biener wrote: > On Mon, May 19, 2014 at 5:24 PM, Xinliang David Li wrote: >> Sorry about it. Here is the patch. There is one remaining case where >> cgraph_dump_file and dump_enable_p are checked separately -- >> cgraph_dump_file is set up differently fro

Re: add dbgcnt and opt-info support for devirtualization

2014-05-20 Thread Richard Biener
On Mon, May 19, 2014 at 5:24 PM, Xinliang David Li wrote: > Sorry about it. Here is the patch. There is one remaining case where > cgraph_dump_file and dump_enable_p are checked separately -- > cgraph_dump_file is set up differently from 'dump_file'. But there you check with an else if, so if yo

Re: add dbgcnt and opt-info support for devirtualization

2014-05-19 Thread Xinliang David Li
Sorry about it. Here is the patch. There is one remaining case where cgraph_dump_file and dump_enable_p are checked separately -- cgraph_dump_file is set up differently from 'dump_file'. David On Mon, May 19, 2014 at 2:21 AM, Richard Biener wrote: > On Fri, May 16, 2014 at 11:19 PM, Xinliang

Re: add dbgcnt and opt-info support for devirtualization

2014-05-19 Thread Richard Biener
On Fri, May 16, 2014 at 11:19 PM, Xinliang David Li wrote: > Modified the patch according to yours and Richard's feedback. PTAL. ENOPATCH. Btw, I don't see any issue with leaking node order to opt-report. Richard. > thanks, > > David > > On Fri, May 16, 2014 at 9:03 AM, Jan Hubicka wrote: >>>

Re: add dbgcnt and opt-info support for devirtualization

2014-05-18 Thread Xinliang David Li
There is no test regression. Ok with this patch? David On Fri, May 16, 2014 at 2:19 PM, Xinliang David Li wrote: > Modified the patch according to yours and Richard's feedback. PTAL. > > thanks, > > David > > On Fri, May 16, 2014 at 9:03 AM, Jan Hubicka wrote: >>> Hi, debugging runtime bugs due

Re: add dbgcnt and opt-info support for devirtualization

2014-05-16 Thread Xinliang David Li
Modified the patch according to yours and Richard's feedback. PTAL. thanks, David On Fri, May 16, 2014 at 9:03 AM, Jan Hubicka wrote: >> Hi, debugging runtime bugs due to devirtualization can be hard for >> very large C++ programs with complicated class hierarchy. This patch >> adds the support

Re: add dbgcnt and opt-info support for devirtualization

2014-05-16 Thread Xinliang David Li
On Fri, May 16, 2014 at 9:51 AM, Jan Hubicka wrote: >> >> I have been chasing a runtime failure of a very large test built with >> gcc-4_9. The bad code either calls a pure function or turn a virtual >> call into __builtin_unreachable (incomplete target set). The indirect >> info shows the otr typ

Re: add dbgcnt and opt-info support for devirtualization

2014-05-16 Thread Jan Hubicka
> > I have been chasing a runtime failure of a very large test built with > gcc-4_9. The bad code either calls a pure function or turn a virtual > call into __builtin_unreachable (incomplete target set). The indirect > info shows the otr type to be !maybe_derived_type, and the outer-type > gets cl

Re: add dbgcnt and opt-info support for devirtualization

2014-05-16 Thread Xinliang David Li
On Fri, May 16, 2014 at 9:03 AM, Jan Hubicka wrote: >> Hi, debugging runtime bugs due to devirtualization can be hard for >> very large C++ programs with complicated class hierarchy. This patch >> adds the support to report this high level transformation via >> -fopt-info (not hidden inside dump f

Re: add dbgcnt and opt-info support for devirtualization

2014-05-16 Thread Jan Hubicka
> Hi, debugging runtime bugs due to devirtualization can be hard for > very large C++ programs with complicated class hierarchy. This patch > adds the support to report this high level transformation via > -fopt-info (not hidden inside dump file) and the ability the do binary > search with cutoff.

Re: add dbgcnt and opt-info support for devirtualization

2014-05-16 Thread Xinliang David Li
On Fri, May 16, 2014 at 4:00 AM, Richard Biener wrote: > On Fri, May 16, 2014 at 1:54 AM, Xinliang David Li wrote: >> Hi, debugging runtime bugs due to devirtualization can be hard for >> very large C++ programs with complicated class hierarchy. This patch >> adds the support to report this high

Re: add dbgcnt and opt-info support for devirtualization

2014-05-16 Thread Richard Biener
On Fri, May 16, 2014 at 1:54 AM, Xinliang David Li wrote: > Hi, debugging runtime bugs due to devirtualization can be hard for > very large C++ programs with complicated class hierarchy. This patch > adds the support to report this high level transformation via > -fopt-info (not hidden inside dump