Re: add ASM_OUTPUT_MAX_SKIP_ALIGN to i386.h

2021-04-28 Thread Uros Bizjak via Gcc-patches
On Thu, Apr 29, 2021 at 6:10 AM Alexandre Oliva wrote: > > On Apr 28, 2021, Uros Bizjak wrote: > > > On a related note, while looking at gcc/config.gcc, I noticed that > > there are two identical code blocks under ${target} i[34567]86-*-* and > > x86-64-*-*. As much as I have eyeballed the code,

Re: add ASM_OUTPUT_MAX_SKIP_ALIGN to i386.h

2021-04-28 Thread Uros Bizjak via Gcc-patches
On Thu, Apr 29, 2021 at 6:04 AM Alexandre Oliva wrote: > > On Apr 28, 2021, Uros Bizjak wrote: > > > i386.h is actually the default $tm_file for i386 and x86_64. It is not > > possible to use x86-64.h without i386.h, so you can simply delete the > > definition in x86-64.h. > > > Regarding _PAD va

Re: add ASM_OUTPUT_MAX_SKIP_ALIGN to i386.h

2021-04-28 Thread Alexandre Oliva
On Apr 28, 2021, Uros Bizjak wrote: > On a related note, while looking at gcc/config.gcc, I noticed that > there are two identical code blocks under ${target} i[34567]86-*-* and > x86-64-*-*. As much as I have eyeballed the code, I can't find the > difference, so perhaps these two blocks should h

Re: add ASM_OUTPUT_MAX_SKIP_ALIGN to i386.h

2021-04-28 Thread Alexandre Oliva
On Apr 28, 2021, Uros Bizjak wrote: > i386.h is actually the default $tm_file for i386 and x86_64. It is not > possible to use x86-64.h without i386.h, so you can simply delete the > definition in x86-64.h. > Regarding _PAD variant, please remove it and substitute #ifdef > ASM_OUTPUT_MAX_SKIP_PA

Re: add ASM_OUTPUT_MAX_SKIP_ALIGN to i386.h

2021-04-28 Thread Uros Bizjak via Gcc-patches
On Tue, Apr 27, 2021 at 5:34 PM Alexandre Oliva wrote: > > > Several i386 align tests expect p2align to be used, but not all > configurations define ASM_OUTPUT_MAX_SKIP_ALIGN, even when > HAVE_GAS_MAX_SKIP_P2ALIGN. > > i386.h has an equivalent ASM_OUTPUT_MAX_SKIP_PAD that is used in > i386.c, so I

Re: add ASM_OUTPUT_MAX_SKIP_ALIGN to i386.h

2021-04-28 Thread Uros Bizjak via Gcc-patches
On Tue, Apr 27, 2021 at 5:34 PM Alexandre Oliva wrote: > > > Several i386 align tests expect p2align to be used, but not all > configurations define ASM_OUTPUT_MAX_SKIP_ALIGN, even when > HAVE_GAS_MAX_SKIP_P2ALIGN. > > i386.h has an equivalent ASM_OUTPUT_MAX_SKIP_PAD that is used in > i386.c, so I