Re: abstract wide int binop code from VRP

2018-07-13 Thread Richard Biener
On Fri, Jul 13, 2018 at 3:18 PM Richard Biener wrote: > > On Fri, Jul 13, 2018 at 10:05 AM Aldy Hernandez wrote: > > > > > > > > On 07/13/2018 03:02 AM, Richard Biener wrote: > > > On Thu, Jul 12, 2018 at 10:12 AM Aldy Hernandez wrote: > > > > > So besides the general discussion about references

Re: abstract wide int binop code from VRP

2018-07-13 Thread Richard Biener
On Fri, Jul 13, 2018 at 10:05 AM Aldy Hernandez wrote: > > > > On 07/13/2018 03:02 AM, Richard Biener wrote: > > On Thu, Jul 12, 2018 at 10:12 AM Aldy Hernandez wrote: > > > So besides the general discussion about references/pointers for out > > parameters > > let's stay consistet within related

Re: abstract wide int binop code from VRP

2018-07-13 Thread Aldy Hernandez
On 07/13/2018 03:02 AM, Richard Biener wrote: On Thu, Jul 12, 2018 at 10:12 AM Aldy Hernandez wrote: So besides the general discussion about references/pointers for out parameters let's stay consistet within related APIs. This means wide_int_binop should have a wide_int wide_int_binop (e

Re: abstract wide int binop code from VRP

2018-07-13 Thread Richard Biener
On Thu, Jul 12, 2018 at 10:12 AM Aldy Hernandez wrote: > > On 07/11/2018 01:33 PM, Richard Sandiford wrote: > > Aldy Hernandez writes: > >> On 07/11/2018 08:52 AM, Richard Biener wrote: > >>> On Wed, Jul 11, 2018 at 8:48 AM Aldy Hernandez wrote: > > Hmmm, I think we can do better, and

Re: abstract wide int binop code from VRP

2018-07-12 Thread Aldy Hernandez
On 07/12/2018 04:29 AM, Richard Sandiford wrote: Aldy Hernandez writes: On 07/11/2018 01:33 PM, Richard Sandiford wrote: Aldy Hernandez writes: On 07/11/2018 08:52 AM, Richard Biener wrote: On Wed, Jul 11, 2018 at 8:48 AM Aldy Hernandez wrote: Hmmm, I think we can do better, and since

Re: abstract wide int binop code from VRP

2018-07-12 Thread Richard Sandiford
Aldy Hernandez writes: > On 07/11/2018 01:33 PM, Richard Sandiford wrote: >> Aldy Hernandez writes: >>> On 07/11/2018 08:52 AM, Richard Biener wrote: On Wed, Jul 11, 2018 at 8:48 AM Aldy Hernandez wrote: > > Hmmm, I think we can do better, and since this hasn't been reviewed yet, >>

Re: abstract wide int binop code from VRP

2018-07-12 Thread Aldy Hernandez
On 07/11/2018 01:33 PM, Richard Sandiford wrote: Aldy Hernandez writes: On 07/11/2018 08:52 AM, Richard Biener wrote: On Wed, Jul 11, 2018 at 8:48 AM Aldy Hernandez wrote: Hmmm, I think we can do better, and since this hasn't been reviewed yet, I don't think anyone will mind the adjustment

Re: abstract wide int binop code from VRP

2018-07-11 Thread Richard Sandiford
Aldy Hernandez writes: > On 07/11/2018 08:52 AM, Richard Biener wrote: >> On Wed, Jul 11, 2018 at 8:48 AM Aldy Hernandez wrote: >>> >>> Hmmm, I think we can do better, and since this hasn't been reviewed yet, >>> I don't think anyone will mind the adjustment to the patch ;-). >>> >>> I really hat

Re: abstract wide int binop code from VRP

2018-07-11 Thread Richard Sandiford
Richard Biener writes: > On Wed, Jul 11, 2018 at 8:48 AM Aldy Hernandez wrote: >> >> Hmmm, I think we can do better, and since this hasn't been reviewed yet, >> I don't think anyone will mind the adjustment to the patch ;-). >> >> I really hate int_const_binop_SOME_RANDOM_NUMBER. We should abstr

Re: abstract wide int binop code from VRP

2018-07-11 Thread Aldy Hernandez
On 07/11/2018 08:52 AM, Richard Biener wrote: On Wed, Jul 11, 2018 at 8:48 AM Aldy Hernandez wrote: Hmmm, I think we can do better, and since this hasn't been reviewed yet, I don't think anyone will mind the adjustment to the patch ;-). I really hate int_const_binop_SOME_RANDOM_NUMBER. We

Re: abstract wide int binop code from VRP

2018-07-11 Thread Richard Biener
On Wed, Jul 11, 2018 at 8:48 AM Aldy Hernandez wrote: > > Hmmm, I think we can do better, and since this hasn't been reviewed yet, > I don't think anyone will mind the adjustment to the patch ;-). > > I really hate int_const_binop_SOME_RANDOM_NUMBER. We should abstract > them into properly named

Re: abstract wide int binop code from VRP

2018-07-10 Thread Aldy Hernandez
Hmmm, I think we can do better, and since this hasn't been reviewed yet, I don't think anyone will mind the adjustment to the patch ;-). I really hate int_const_binop_SOME_RANDOM_NUMBER. We should abstract them into properly named poly_int_binop, wide_int_binop, and tree_binop, and then use a