Re: V3 [PATCH] Use SHF_GNU_RETAIN to preserve symbol definitions

2020-12-02 Thread Joseph Myers
On Wed, 2 Dec 2020, H.J. Lu via Gcc-patches wrote: > > Not sure if this is a GCC bug or indicates that glibc's libc_freeres_fn or > > related macros need to change to work with both old and new GCC. > > We may need to update glibc for GCC 11. Can you open a glibc bug and > CC me? https://source

Re: V3 [PATCH] Use SHF_GNU_RETAIN to preserve symbol definitions

2020-12-02 Thread H.J. Lu via Gcc-patches
On Wed, Dec 2, 2020 at 1:31 PM Joseph Myers wrote: > > This patch (GCC commit 6fbec038f7a7ddf29f074943611b53210d17c40c) has > broken the glibc build (at least with current binutils master). The > errors are of the form: > > In file included from : > gconv_dl.c: In function 'free_mem': > gconv_dl.

Re: V3 [PATCH] Use SHF_GNU_RETAIN to preserve symbol definitions

2020-12-02 Thread Joseph Myers
This patch (GCC commit 6fbec038f7a7ddf29f074943611b53210d17c40c) has broken the glibc build (at least with current binutils master). The errors are of the form: In file included from : gconv_dl.c: In function 'free_mem': gconv_dl.c:202:18: error: 'free_mem' causes a section type conflict with

Re: V3 [PATCH] Use SHF_GNU_RETAIN to preserve symbol definitions

2020-12-01 Thread Jeff Law via Gcc-patches
On 12/1/20 5:36 PM, H.J. Lu wrote: > On Tue, Dec 1, 2020 at 4:04 PM Jeff Law wrote: >> >> >> On 11/17/20 6:20 AM, H.J. Lu via Gcc-patches wrote: >>> On Mon, Nov 16, 2020 at 7:59 PM Hans-Peter Nilsson >>> wrote: On Fri, 13 Nov 2020, H.J. Lu via Gcc-patches wrote: > Done. Here is the