Re: Unordered container insertion hints

2013-06-29 Thread François Dumont
Patch applied, I also needed to update some dg-error line numbers, it was not part of the original patch. The only remaining thing will be to update the doxygen links on the unordered containers to point to the new hint doc. 2013-06-29 François Dumont * include/bits/hashtable_policy.h

Re: Unordered container insertion hints

2013-06-28 Thread Jonathan Wakely
On 23 June 2013 13:51, Jonathan Wakely wrote: > On 19 June 2013 20:56, François Dumont wrote: >> Still no chance to have a look ? > > I'll try to finish reviewing it today, thanks for the reminder. Sorry for the delay. The patch is OK, with a few small changes to the new docs: Please change

Re: Unordered container insertion hints

2013-06-23 Thread Jonathan Wakely
On 19 June 2013 20:56, François Dumont wrote: > Still no chance to have a look ? I'll try to finish reviewing it today, thanks for the reminder.

Re: Unordered container insertion hints

2013-06-19 Thread François Dumont
Still no chance to have a look ? I think that that patch is a really safe one. Those that do not use hint won't be impacted. Those that are already using it without any reason might experiment a small performance issue if they found the way to always use the worst possible hint. Fran

Re: Unordered container insertion hints

2013-06-12 Thread François Dumont
Hi Any news regarding this patch ? Thanks François On 06/06/2013 10:33 PM, François Dumont wrote: On 05/24/2013 01:00 AM, Paolo Carlini wrote: On 05/23/2013 10:01 PM, François Dumont wrote: Some feedback regarding this patch ? Two quick ones: what if the hint is wrong? I suppose the in

Re: Unordered container insertion hints

2013-06-06 Thread François Dumont
On 05/24/2013 01:00 AM, Paolo Carlini wrote: On 05/23/2013 10:01 PM, François Dumont wrote: Some feedback regarding this patch ? Two quick ones: what if the hint is wrong? I suppose the insertion succeeds anyway, it's only a little waste of time, right? Right. Is it possible that for instanc

Re: Unordered container insertion hints

2013-05-23 Thread Paolo Carlini
On 05/23/2013 10:01 PM, François Dumont wrote: Some feedback regarding this patch ? Two quick ones: what if the hint is wrong? I suppose the insertion succeeds anyway, it's only a little waste of time, right? Is it possible that for instance something throws in that case and would not now (when

Re: Unordered container insertion hints

2013-05-23 Thread François Dumont
Some feedback regarding this patch ? Thanks On 05/15/2013 09:49 PM, François Dumont wrote: Hi Here is a patch to consider the hint that users can give to enhancement insertion performances. As you can see I only use it for unordered_multi* containers to potentially avoid research within