Re: Tweak ALAP calculation in SCHED_PRESSURE_MODEL

2018-11-20 Thread Pat Haugen
On 11/20/18 10:53 AM, Kyrill Tkachov wrote: > On 20/11/18 16:48, Pat Haugen wrote: >> On 11/19/18 2:30 PM, Pat Haugen wrote: This is a follow-up from https://gcc.gnu.org/ml/gcc-patches/2018-11/msg01525.html This version introduces an "artificial" property of the dependencies p

Re: Tweak ALAP calculation in SCHED_PRESSURE_MODEL

2018-11-20 Thread Kyrill Tkachov
On 20/11/18 16:48, Pat Haugen wrote: On 11/19/18 2:30 PM, Pat Haugen wrote: This is a follow-up from https://gcc.gnu.org/ml/gcc-patches/2018-11/msg01525.html This version introduces an "artificial" property of the dependencies produced in sched-deps.c that is recorded when they are created du

Re: Tweak ALAP calculation in SCHED_PRESSURE_MODEL

2018-11-20 Thread Pat Haugen
On 11/19/18 2:30 PM, Pat Haugen wrote: >> This is a follow-up from >> https://gcc.gnu.org/ml/gcc-patches/2018-11/msg01525.html >> This version introduces an "artificial" property of the dependencies >> produced in >> sched-deps.c that is recorded when they are created due to >> MAX_PENDING_LIST_

Re: Tweak ALAP calculation in SCHED_PRESSURE_MODEL

2018-11-19 Thread Pat Haugen
On 11/19/18 11:54 AM, Kyrill Tkachov wrote: > On 16/11/18 18:19, Pat Haugen wrote: >> On 11/8/18 6:10 AM, Kyrill Tkachov wrote: >>> The attached patch avoids that by making the alap calculation only >>> look at true dependencies.  This shouldn't be too bad, since we use >>> INSN_PRIORITY as the fin

Re: Tweak ALAP calculation in SCHED_PRESSURE_MODEL

2018-11-19 Thread Kyrill Tkachov
On 16/11/18 18:19, Pat Haugen wrote: On 11/8/18 6:10 AM, Kyrill Tkachov wrote: The attached patch avoids that by making the alap calculation only look at true dependencies. This shouldn't be too bad, since we use INSN_PRIORITY as the final tie-breaker than that does take anti-dependencies into

Re: Tweak ALAP calculation in SCHED_PRESSURE_MODEL

2018-11-16 Thread Kyrill Tkachov
On 16/11/18 18:19, Pat Haugen wrote: On 11/8/18 6:10 AM, Kyrill Tkachov wrote: > The attached patch avoids that by making the alap calculation only > look at true dependencies. This shouldn't be too bad, since we use > INSN_PRIORITY as the final tie-breaker than that does take > anti-dependenc

Re: Tweak ALAP calculation in SCHED_PRESSURE_MODEL

2018-11-16 Thread Pat Haugen
On 11/8/18 6:10 AM, Kyrill Tkachov wrote: > The attached patch avoids that by making the alap calculation only > look at true dependencies.  This shouldn't be too bad, since we use > INSN_PRIORITY as the final tie-breaker than that does take > anti-dependencies into account. > > This reduces the n

Re: Tweak ALAP calculation in SCHED_PRESSURE_MODEL

2018-11-16 Thread Jeff Law
On 11/16/18 10:21 AM, Kyrill Tkachov wrote: > It probably wouldn't be a bad idea to look at the default for MAX_PENDING_LIST_LENGTH.  Based on the current default value and the comments in the code that value could well have been tuned 25 or more years ago! >>> Probably. I see

Re: Tweak ALAP calculation in SCHED_PRESSURE_MODEL

2018-11-16 Thread Kyrill Tkachov
Hi Jeff, On 16/11/18 17:08, Jeff Law wrote: On 11/16/18 5:35 AM, Kyrill Tkachov wrote: But more importantly, it seems like blindly ignoring anti dependencies is just a hack that happens to work. I wonder if we could somehow mark the fake dependencies we add, and avoid bumping the ALAP when we

Re: Tweak ALAP calculation in SCHED_PRESSURE_MODEL

2018-11-16 Thread Jeff Law
On 11/16/18 5:35 AM, Kyrill Tkachov wrote: > >> But more importantly, it seems like blindly ignoring anti dependencies >> is just a hack that happens to work.  I wonder if we could somehow mark >> the fake dependencies we add, and avoid bumping the ALAP when we >> encounter those fake dependencies

Re: Tweak ALAP calculation in SCHED_PRESSURE_MODEL

2018-11-16 Thread Kyrill Tkachov
Hi Jeff, On 10/11/18 00:04, Jeff Law wrote: On 11/8/18 5:10 AM, Kyrill Tkachov wrote: This patch fixes a flaw in the relationship between the way that SCHED_PRESSURE_MODEL calculates the alap and depth vs how it uses them in model_order_p. A comment in model_order_p says: /* Combine the

Re: Tweak ALAP calculation in SCHED_PRESSURE_MODEL

2018-11-09 Thread Jeff Law
On 11/8/18 5:10 AM, Kyrill Tkachov wrote: > > > This patch fixes a flaw in the relationship between the way that > SCHED_PRESSURE_MODEL calculates the alap and depth vs how it uses > them in model_order_p.  A comment in model_order_p says: > >   /* Combine the length of the longest path of satis