Re: Speculative call support in the callgraph

2013-08-10 Thread Jan Hubicka
> > Hi, > > also I just became aware that this patch hits the following bug of gold > > http://sourceware.org/bugzilla/show_bug.cgi?id=14342 > > It makes gcc.dg/tree-prof/crossmodule-indircall-1.c fail with the bogus > > diagnostic on TLS and non-TLS use of the same symbol. I attached the > > deta

Re: Speculative call support in the callgraph

2013-08-10 Thread Andi Kleen
I can confirm that trunk bootstraps again. Thanks. Now if someone could please fix http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58090 too (bootstrap comparison failure with --enable-gather-detailed-mem-stats) -Andi -- a...@linux.intel.com -- Speaking for myself only.

Re: Speculative call support in the callgraph

2013-08-10 Thread Jan Hubicka
> Hi, > also I just became aware that this patch hits the following bug of gold > http://sourceware.org/bugzilla/show_bug.cgi?id=14342 > It makes gcc.dg/tree-prof/crossmodule-indircall-1.c fail with the bogus > diagnostic on TLS and non-TLS use of the same symbol. I attached the > details into the

Re: Speculative call support in the callgraph

2013-08-10 Thread Jan Hubicka
> This is really strange. The speculative edges should not be created here at > all. > So perhaps some uninitialized memory access crept in :( > It would help if you try to track how the ->speculative bit appears for you > in the loop in cgraph_rebuild_references. I will try to reproduce your set

Re: Speculative call support in the callgraph

2013-08-10 Thread Jan Hubicka
Hi, also I just became aware that this patch hits the following bug of gold http://sourceware.org/bugzilla/show_bug.cgi?id=14342 It makes gcc.dg/tree-prof/crossmodule-indircall-1.c fail with the bogus diagnostic on TLS and non-TLS use of the same symbol. I attached the details into the PR. GNU-LD

Re: Speculative call support in the callgraph

2013-08-10 Thread Jan Hubicka
> On Sat, Aug 10, 2013 at 02:25:21AM +0200, Andi Kleen wrote: > > On Sat, Aug 10, 2013 at 01:15:11AM +0200, Jan Hubicka wrote: > > > > Jan Hubicka writes: > > > > > > > > > Hi, > > > > > this patch adds support for speculative calls into callgraph. The > > > > > idea is that > > > > > any IPA o

Re: Speculative call support in the callgraph

2013-08-09 Thread Andi Kleen
On Sat, Aug 10, 2013 at 02:25:21AM +0200, Andi Kleen wrote: > On Sat, Aug 10, 2013 at 01:15:11AM +0200, Jan Hubicka wrote: > > > Jan Hubicka writes: > > > > > > > Hi, > > > > this patch adds support for speculative calls into callgraph. The idea > > > > is that > > > > any IPA optimization that

Re: Speculative call support in the callgraph

2013-08-09 Thread Andi Kleen
On Sat, Aug 10, 2013 at 01:15:11AM +0200, Jan Hubicka wrote: > > Jan Hubicka writes: > > > > > Hi, > > > this patch adds support for speculative calls into callgraph. The idea > > > is that > > > any IPA optimization that believes it knows likely target of an indirect > > > call > > > (current

Re: Speculative call support in the callgraph

2013-08-09 Thread Xinliang David Li
On Fri, Aug 9, 2013 at 4:21 PM, Jan Hubicka wrote: >> On Fri, Aug 9, 2013 at 1:24 PM, Jan Hubicka wrote: >> >> I have not looked at the details. One high level question: this form >> >> seems to only support one indirect target case. LIPO uses TOPN >> >> indirect target profiling (tracking multip

Re: Speculative call support in the callgraph

2013-08-09 Thread Jan Hubicka
> On Fri, Aug 9, 2013 at 1:24 PM, Jan Hubicka wrote: > >> I have not looked at the details. One high level question: this form > >> seems to only support one indirect target case. LIPO uses TOPN > >> indirect target profiling (tracking multiple targets), which can be > >> used by LTO as well (when

Re: Speculative call support in the callgraph

2013-08-09 Thread Jan Hubicka
> Jan Hubicka writes: > > > Hi, > > this patch adds support for speculative calls into callgraph. The idea is > > that > > any IPA optimization that believes it knows likely target of an indirect > > call > > (currently I use it for cross-module indirect call profiling, but I expect > > Martin

Re: Speculative call support in the callgraph

2013-08-09 Thread Xinliang David Li
On Fri, Aug 9, 2013 at 1:24 PM, Jan Hubicka wrote: >> I have not looked at the details. One high level question: this form >> seems to only support one indirect target case. LIPO uses TOPN >> indirect target profiling (tracking multiple targets), which can be >> used by LTO as well (when the topn

Re: Speculative call support in the callgraph

2013-08-09 Thread Andi Kleen
Jan Hubicka writes: > Hi, > this patch adds support for speculative calls into callgraph. The idea is > that > any IPA optimization that believes it knows likely target of an indirect call > (currently I use it for cross-module indirect call profiling, but I expect > Martin J. can easily add su

Re: Speculative call support in the callgraph

2013-08-09 Thread Jan Hubicka
> I have not looked at the details. One high level question: this form > seems to only support one indirect target case. LIPO uses TOPN > indirect target profiling (tracking multiple targets), which can be > used by LTO as well (when the topn profiling gets into trunk). Well, adding multiple direc