Re: Silence merge warnings on artificial types

2015-04-03 Thread Jakub Jelinek
On Thu, Apr 02, 2015 at 09:05:53PM +0200, Jakub Jelinek wrote: > On Thu, Apr 02, 2015 at 09:23:03PM +0300, Ilya Verbin wrote: > > Hmm, libgomp.c++/target-3.C still fails. > > Here is what I see in need_assembler_name_p: > > Guess we should make the .omp_data_s.* types TYPE_ARTIFICIAL too. > Will t

Re: Silence merge warnings on artificial types

2015-04-02 Thread Jakub Jelinek
On Thu, Apr 02, 2015 at 09:23:03PM +0300, Ilya Verbin wrote: > Hmm, libgomp.c++/target-3.C still fails. > Here is what I see in need_assembler_name_p: Guess we should make the .omp_data_s.* types TYPE_ARTIFICIAL too. Will take care of that tomorrow. Jakub

Re: Silence merge warnings on artificial types

2015-04-02 Thread Jan Hubicka
> On Tue, Mar 31, 2015 at 09:51:21 +0200, Jan Hubicka wrote: > > this patch adds the ARTIFICIAL flag check to avoid ODR merging to these. > > I oriignally tested DECL_ARTIFICIAL (decl) (that is TYPE_NAME) that randomly > > dropped type names on some classes but not all. > > > > Jason, please do yo

Re: Silence merge warnings on artificial types

2015-04-02 Thread Ilya Verbin
On Tue, Mar 31, 2015 at 09:51:21 +0200, Jan Hubicka wrote: > this patch adds the ARTIFICIAL flag check to avoid ODR merging to these. > I oriignally tested DECL_ARTIFICIAL (decl) (that is TYPE_NAME) that randomly > dropped type names on some classes but not all. > > Jason, please do you know what

Re: Silence merge warnings on artificial types

2015-03-31 Thread Jason Merrill
On 03/31/2015 03:51 AM, Jan Hubicka wrote: Jason, please do you know what is meaning of DECL_ARTIFICIAL on class type names? Perhaps we can drop them to 0 in free lang data? It indicates the implicit typedef that let's you say 'S' instead of 'struct S' without writing 'typedef struct S S' your

Re: Silence merge warnings on artificial types

2015-03-31 Thread Jan Hubicka
> On 03/30/2015 01:23 PM, Jan Hubicka wrote: > >Jason probably knows better, but I think only real C++ types comply the One > >Defintion > >Type and should be merged. Anything we create artifically in compiler is > >probably > >not covered by this. > > Agreed, compiler internals are outside the