Re: S/390: Fix warnings in "*setmem_long..." patterns.

2015-12-11 Thread Andreas Krebbel
On 12/04/2015 06:15 PM, Dominik Vogt wrote: > Version 5 with the latest requested changes. Seems to work now. > I've dropped the extra patch and rather marked the failing tests > as "xfail". > > Ciao > > Dominik ^_^ ^_^ > Patch applied with minor changes: > + ; Convert Pmode to BLKmode > +

Re: S/390: Fix warnings in "*setmem_long..." patterns.

2015-12-04 Thread Dominik Vogt
Version 5 with the latest requested changes. Seems to work now. I've dropped the extra patch and rather marked the failing tests as "xfail". Ciao Dominik ^_^ ^_^ -- Dominik Vogt IBM Germany gcc/ChangeLog * config/s390/s390.c (s390_expand_setmem): Use new expanders. * config/

Re: S/390: Fix warnings in "*setmem_long..." patterns.

2015-12-02 Thread Andreas Krebbel
On 12/02/2015 02:11 PM, Andreas Krebbel wrote: > On 12/02/2015 01:51 PM, Ulrich Weigand wrote: >> Andreas Krebbel wrote: >>> On 12/02/2015 11:12 AM, Dominik Vogt wrote: Hopefully, this is correct now; it does pass the functional test case that's part of the patch. Unfortunately the defin

Re: S/390: Fix warnings in "*setmem_long..." patterns.

2015-12-02 Thread Andreas Krebbel
On 12/02/2015 01:51 PM, Ulrich Weigand wrote: > Andreas Krebbel wrote: >> On 12/02/2015 11:12 AM, Dominik Vogt wrote: >>> Hopefully, this is correct now; it does pass the functional test case >>> that's part of the patch. Unfortunately the define_insn patters >>> had to be duplicated because of th

Re: S/390: Fix warnings in "*setmem_long..." patterns.

2015-12-02 Thread Ulrich Weigand
Andreas Krebbel wrote: > On 12/02/2015 11:12 AM, Dominik Vogt wrote: > > Hopefully, this is correct now; it does pass the functional test case > > that's part of the patch. Unfortunately the define_insn patters > > had to be duplicated because of the new subreg offsets. > > The number of patter

Re: S/390: Fix warnings in "*setmem_long..." patterns.

2015-12-02 Thread Andreas Krebbel
On 12/02/2015 11:12 AM, Dominik Vogt wrote: > Hopefully, this is correct now; it does pass the functional test case > that's part of the patch. Unfortunately the define_insn patters > had to be duplicated because of the new subreg offsets. The number of patterns could possibly be reduced using

Re: S/390: Fix warnings in "*setmem_long..." patterns.

2015-12-02 Thread Dominik Vogt
Hopefully, this is correct now; it does pass the functional test case that's part of the patch. Unfortunately the define_insn patters had to be duplicated because of the new subreg offsets. Not sure whether I've missed any "use" patterns that should be added. Ciao Dominik ^_^ ^_^ -- Dominik

Re: S/390: Fix warnings in "*setmem_long..." patterns.

2015-12-01 Thread Dominik Vogt
On Tue, Dec 01, 2015 at 10:59:54AM +0100, Dominik Vogt wrote: > @@ -3336,11 +3342,12 @@ > (set_attr "type" "vs")]) > > (define_insn "*setmem_long_31z" > - [(clobber (match_operand:TI 0 "register_operand" "=d")) > - (set (mem:BLK (subreg:SI (match_operand:TI 3 "register_operand" "0") 4)) >

Re: S/390: Fix warnings in "*setmem_long..." patterns.

2015-12-01 Thread Dominik Vogt
On Mon, Nov 30, 2015 at 06:11:33PM +0100, Ulrich Weigand wrote: > On 11/30/2015 04:11 PM, Dominik Vogt wrote: > > The attached patch fixes some warnings generated by the setmem... > > patterns in s390.md during build and add test cases for the > > patterns. The patch is to be added on to p of the

Re: S/390: Fix warnings in "*setmem_long..." patterns.

2015-11-30 Thread Andreas Krebbel
On 11/30/2015 06:11 PM, Ulrich Weigand wrote: ... > However, I agree that UNSPEC_P_TO_BLK really should also get the length > as input, to make it have precisely defined semantics. Also, I'd rather > use a more descriptive name, like UNSPEC_REPLICATE_BYTE or the like. > > What would you think abo

Re: S/390: Fix warnings in "*setmem_long..." patterns.

2015-11-30 Thread Ulrich Weigand
Andreas Krebbel wrote: > On 11/30/2015 04:11 PM, Dominik Vogt wrote: > > The attached patch fixes some warnings generated by the setmem... > > patterns in s390.md during build and add test cases for the > > patterns. The patch is to be added on to p of the movstr patch: > > https://gcc.gnu.org/ml/

Re: S/390: Fix warnings in "*setmem_long..." patterns.

2015-11-30 Thread Andreas Krebbel
On 11/30/2015 04:11 PM, Dominik Vogt wrote: > The attached patch fixes some warnings generated by the setmem... > patterns in s390.md during build and add test cases for the > patterns. The patch is to be added on to p of the movstr patch: > https://gcc.gnu.org/ml/gcc-patches/2015-11/msg03485.html