RE: Rewrite assign_discriminators pass

2025-07-12 Thread Robert Dubner
nvidia.com; ja...@redhat.com; James K. > Lowden > Subject: RE: Rewrite assign_discriminators pass > > Please be aware that something introduced in > > 385d9937f0e - Rewrite assign_discriminators > > has since caused a "make cobol-check" failure. The backtrace

RE: Rewrite assign_discriminators pass

2025-07-12 Thread Robert Dubner
ing this discussion, but I figured I should let you know. > -Original Message- > From: Jan Hubicka > Sent: Saturday, July 12, 2025 08:08 > To: H.J. Lu > Cc: Richard Biener ; gcc-patches@gcc.gnu.org; > kvivekana...@nvidia.com; dhr...@nvidia.com; ja...@redhat

Re: Rewrite assign_discriminators pass

2025-07-12 Thread Jan Hubicka
> > This caused: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=121045 I see, -compare-debug actually compares discriminators in dump of final pass. Discriminators do not need to be the same if they are unused and they are consumed only by dwaf2out and by auto-profile, so I think compare-debu

Re: Rewrite assign_discriminators pass

2025-07-11 Thread H.J. Lu
On Fri, Jul 11, 2025 at 7:32 PM Jan Hubicka wrote: > > > So with this the discriminator we assign might depend on whether > > we have debug stmts or not. We output them only to debug info, so > > it should in principle not cause compare-debug issues, right? And > > we don't use discriminators to

Re: Rewrite assign_discriminators pass

2025-07-11 Thread Andrew Pinski
On Fri, Jul 11, 2025 at 2:26 AM Richard Biener wrote: > > On Thu, 10 Jul 2025, Jan Hubicka wrote: > > > Hi, > > to assign debug locations to corresponding statements auto-fdo uses > > discriminators. Documentation says that if given statement belongs to > > multiple > > basic blocks, the discrmi

Re: Rewrite assign_discriminators pass

2025-07-11 Thread Jan Hubicka
> So with this the discriminator we assign might depend on whether > we have debug stmts or not. We output them only to debug info, so > it should in principle not cause compare-debug issues, right? And > we don't use discriminators to affect code generation (hopefully). This is the reason of op

Re: Rewrite assign_discriminators pass

2025-07-11 Thread Richard Biener
On Thu, 10 Jul 2025, Jan Hubicka wrote: > Hi, > to assign debug locations to corresponding statements auto-fdo uses > discriminators. Documentation says that if given statement belongs to > multiple > basic blocks, the discrminator distinguishes them. > > Current implementation however only wor