Re: Reorgnanization of profile count maintenance code, part 1

2017-06-09 Thread Jan Hubicka
> On Tue, Jun 6, 2017 at 1:00 AM, Jan Hubicka wrote: > >> On Thu, Jun 1, 2017 at 4:35 AM, Jan Hubicka wrote: > >> > Index: profile.c > >> > === > >> > --- profile.c (revision 248684) > >> > +++ profile.c (working copy) > >> > @@

Re: Reorgnanization of profile count maintenance code, part 1

2017-06-08 Thread Jason Merrill
On Tue, Jun 6, 2017 at 1:00 AM, Jan Hubicka wrote: >> On Thu, Jun 1, 2017 at 4:35 AM, Jan Hubicka wrote: >> > Index: profile.c >> > === >> > --- profile.c (revision 248684) >> > +++ profile.c (working copy) >> > @@ -67,6 +67,10 @

Re: Reorgnanization of profile count maintenance code, part 1

2017-06-07 Thread Segher Boessenkool
On Wed, Jun 07, 2017 at 11:11:08PM +0200, Jan Hubicka wrote: > > On Tue, Jun 06, 2017 at 10:25:29PM +0200, Jan Hubicka wrote: > > > > On Thu, Jun 01, 2017 at 01:35:56PM +0200, Jan Hubicka wrote: > > > > > + /* FIXME: shrink wrapping violates this sanity check. */ > > > > > + gcc_checking

Re: Reorgnanization of profile count maintenance code, part 1

2017-06-07 Thread Jan Hubicka
> On Tue, Jun 06, 2017 at 10:25:29PM +0200, Jan Hubicka wrote: > > > On Thu, Jun 01, 2017 at 01:35:56PM +0200, Jan Hubicka wrote: > > > > + /* FIXME: shrink wrapping violates this sanity check. */ > > > > + gcc_checking_assert ((num >= 0 > > > > + && (num <= REG

Re: Reorgnanization of profile count maintenance code, part 1

2017-06-07 Thread Segher Boessenkool
On Tue, Jun 06, 2017 at 10:25:29PM +0200, Jan Hubicka wrote: > > On Thu, Jun 01, 2017 at 01:35:56PM +0200, Jan Hubicka wrote: > > > + /* FIXME: shrink wrapping violates this sanity check. */ > > > + gcc_checking_assert ((num >= 0 > > > + && (num <= REG_BR_PROB_BASE >

Re: Reorgnanization of profile count maintenance code, part 1

2017-06-06 Thread Jan Hubicka
> Hi! > > On Thu, Jun 01, 2017 at 01:35:56PM +0200, Jan Hubicka wrote: > > + /* FIXME: shrink wrapping violates this sanity check. */ > > + gcc_checking_assert ((num >= 0 > > + && (num <= REG_BR_PROB_BASE > > + || den <= REG_BR_PROB_BASE)

Re: Reorgnanization of profile count maintenance code, part 1

2017-06-06 Thread Segher Boessenkool
Hi! On Thu, Jun 01, 2017 at 01:35:56PM +0200, Jan Hubicka wrote: > + /* FIXME: shrink wrapping violates this sanity check. */ > + gcc_checking_assert ((num >= 0 > + && (num <= REG_BR_PROB_BASE > + || den <= REG_BR_PROB_BASE) > +

Re: Reorgnanization of profile count maintenance code, part 1

2017-06-06 Thread Jan Hubicka
> On Thu, Jun 1, 2017 at 4:35 AM, Jan Hubicka wrote: > > Index: profile.c > > === > > --- profile.c (revision 248684) > > +++ profile.c (working copy) > > @@ -67,6 +67,10 @@ along with GCC; see the file COPYING3. > > > > #include

Re: Reorgnanization of profile count maintenance code, part 1

2017-06-05 Thread Jason Merrill
On Thu, Jun 1, 2017 at 4:35 AM, Jan Hubicka wrote: > Index: profile.c > === > --- profile.c (revision 248684) > +++ profile.c (working copy) > @@ -67,6 +67,10 @@ along with GCC; see the file COPYING3. > > #include "profile.h" > >

Re: Reorgnanization of profile count maintenance code, part 1

2017-06-05 Thread Jan Hubicka
> > I seeing the following error while building aarch64-elf: > > Same thing on darwin!-( Ooops, I managed to accidentally change my bootstrap tree. I have reverted that change now. Honza > > TIA > > Dominique

Re: Reorgnanization of profile count maintenance code, part 1

2017-06-05 Thread Dominique d'Humières
> I seeing the following error while building aarch64-elf: Same thing on darwin!-( TIA Dominique

Re: Reorgnanization of profile count maintenance code, part 1

2017-06-05 Thread Andrew Pinski
On Mon, Jun 5, 2017 at 8:37 AM, Jan Hubicka wrote: > Hi, > I have committed the following fix. I seeing the following error while building aarch64-elf: /home/jenkins/workspace/BuildToolchainAARCH64_thunder_elf_upstream/toolchain/scripts/../src/gcc/shrink-wrap.c: In function ‘void handle_simple_

Re: Reorgnanization of profile count maintenance code, part 1

2017-06-05 Thread Jan Hubicka
Hi, I have committed the following fix. Honza Index: ChangeLog === --- ChangeLog (revision 248878) +++ ChangeLog (working copy) @@ -1,5 +1,10 @@ 2017-06-05 Jan Hubicka + * config/mips/frame-header-opt.c: Include profi

Re: Reorgnanization of profile count maintenance code, part 1

2017-06-05 Thread Jan Hubicka
Hi, sorry for that. I am testing the obvious change to add #include "profile-count.h" into relevant target files. Honza > I'm seeing a build failure for mips64-linux-gnu: > > In file included from > /scratch/jmyers/glibc-bot/src/gcc/gcc/config/mips/frame-header-opt.c:35:0: > /scratch/jmyers/g

Re: Reorgnanization of profile count maintenance code, part 1

2017-06-05 Thread Joseph Myers
I'm seeing a build failure for mips64-linux-gnu: In file included from /scratch/jmyers/glibc-bot/src/gcc/gcc/config/mips/frame-header-opt.c:35:0: /scratch/jmyers/glibc-bot/src/gcc/gcc/cfg.h:106:64: error: 'profile_count' has not been declared extern void update_bb_profile_for_threading (basic_b

Re: Reorgnanization of profile count maintenance code, part 1

2017-06-04 Thread Jan Hubicka
Hello, thanks for proofreading! > On Thu, Jun 01, 2017 at 01:35:56PM +0200, Jan Hubicka wrote: > > Just some very minor nits. > > > Index: final.c > > === > > --- final.c (revision 248684) > > +++ final.c (working copy) > > @@ -1951,

Re: Reorgnanization of profile count maintenance code, part 1

2017-06-03 Thread Bernhard Reutner-Fischer
On Thu, Jun 01, 2017 at 01:35:56PM +0200, Jan Hubicka wrote: Just some very minor nits. > Index: final.c > === > --- final.c (revision 248684) > +++ final.c (working copy) > @@ -1951,9 +1951,11 @@ dump_basic_block_info (FILE *fil