Re: Remove vtable_method field in cgraph_node

2011-04-20 Thread Martin Jambor
Hi, On Sun, Apr 17, 2011 at 06:34:59PM +0200, Jan Hubicka wrote: > Hi, > > this patch drops vtable_method filed. I never understood what it is > about but reading PR20991 I am convinced that we hit the same > problem with work on new devirutalization code. I implemented what > Mark describe as "i

Re: Remove vtable_method field in cgraph_node

2011-04-18 Thread Jan Hubicka
> On Mon, 18 Apr 2011, Jan Hubicka wrote: > > > > Ah, no. We _did_ that in CCP but now we only adjust the OBJ_TYPE_REF > > > expr in CCP and defer to fold_stmt to eventually "devirtualize" it. > > > See PR45878. Then rev.165435 was necessary, as we dropped OBJ_TYPE_REF > > > for the non-devirtua

Re: Remove vtable_method field in cgraph_node

2011-04-18 Thread Richard Guenther
On Mon, 18 Apr 2011, Jan Hubicka wrote: > > Ah, no. We _did_ that in CCP but now we only adjust the OBJ_TYPE_REF > > expr in CCP and defer to fold_stmt to eventually "devirtualize" it. > > See PR45878. Then rev.165435 was necessary, as we dropped OBJ_TYPE_REF > > for the non-devirtualized call a

Re: Remove vtable_method field in cgraph_node

2011-04-18 Thread Jan Hubicka
> Ah, no. We _did_ that in CCP but now we only adjust the OBJ_TYPE_REF > expr in CCP and defer to fold_stmt to eventually "devirtualize" it. > See PR45878. Then rev.165435 was necessary, as we dropped OBJ_TYPE_REF > for the non-devirtualized call as well. As both cases were because Hmm, sounds

Re: Remove vtable_method field in cgraph_node

2011-04-18 Thread Richard Guenther
On Mon, 18 Apr 2011, Jan Hubicka wrote: > > > notice that OBJ_TYPE_REF is useless since foo got devitualized and it > > > holds alive > > > the useless s._vptr.S = &_ZTV1S[2]. We want to drop OBJ_TYPE_REF at time > > > we fold > > > first argument to constant. > > > > At some point we dropped

Re: Remove vtable_method field in cgraph_node

2011-04-17 Thread Jan Hubicka
> > notice that OBJ_TYPE_REF is useless since foo got devitualized and it holds > > alive > > the useless s._vptr.S = &_ZTV1S[2]. We want to drop OBJ_TYPE_REF at time > > we fold > > first argument to constant. > > At some point we dropped all OBJ_TYPE_REF with direct fn but that lead to > issu

Re: Remove vtable_method field in cgraph_node

2011-04-17 Thread Richard Guenther
On Sun, 17 Apr 2011, Jan Hubicka wrote: > Hi, > this patch drops vtable_method filed. I never understood what it is about but > reading > PR20991 I am convinced that we hit the same problem with work on new > devirutalization code. > I implemented what Mark describe as "ideal solution" there - i