Re: Remove early inlining from afdo pass

2025-06-27 Thread Jan Hubicka
Hi, > > We can look into this. We do compare manually the IR dumps from both and it > is not ideal. > What we should do is an additional (optional) pass that runs after > auto-profile to compare the annotations > using the profile-use. We will have to filter out any functions/path that > runs

Re: Remove early inlining from afdo pass

2025-06-26 Thread Kugan Vivekanandarajah
Hi Honza, > On 27 Jun 2025, at 1:03 am, Jan Hubicka wrote: > > External email: Use caution opening links or attachments > > >> >> >>> On 24 Jun 2025, at 7:43 pm, Jan Hubicka wrote: >>> >>> External email: Use caution opening links or attachments >>> >>> >>> Hi, >>> this pass removes earl

Re: Remove early inlining from afdo pass

2025-06-26 Thread Jan Hubicka
> > > > On 24 Jun 2025, at 7:43 pm, Jan Hubicka wrote: > > > > External email: Use caution opening links or attachments > > > > > > Hi, > > this pass removes early-inlining from afdo pass since all inlining > > should now happen from early inliner. I tedted this on spec and there > > are 3 i

Re: Remove early inlining from afdo pass

2025-06-26 Thread Kugan Vivekanandarajah
> On 24 Jun 2025, at 7:43 pm, Jan Hubicka wrote: > > External email: Use caution opening links or attachments > > > Hi, > this pass removes early-inlining from afdo pass since all inlining > should now happen from early inliner. I tedted this on spec and there > are 3 inlines happening here