Re: Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

2023-10-06 Thread Feng Wang
Hi, Kito & Jeff Due to National Day reasons, I was unable to reply to the email in a timely manner. Thank you for making the necessary changes to this patch. For the introduction of this bug, I will also carefully summarize my experience and lessons to avoid the recurrence of such problems. T

Re: Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

2023-09-06 Thread Feng Wang
Thanks reminder, I should rebase again. -- Feng Wang >Hi, > >I will need to notify you that x_riscv_xventana_subext, >MASK_XVENTANACONDOPS and TARGET_XVENTANACONDOPS are added (I think you >want to rewrite those definitions like the rest).  Also, be careful not >to remove TARGET_ZICOND_

Re: Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

2023-09-06 Thread Kito Cheng via Gcc-patches
I saw RVC has MASK_RVC and TARGET_RVC in options.h? On Wed, Sep 6, 2023 at 2:39 PM Feng Wang wrote: > > According to the doc, take“Mask(VECTOR_ELEN_32) > Var(riscv_vector_elen_flags)”as example, > it just generates the OPTION_MASK_VECTOR_ELEN_32, will not generate > MASK_VECTOR_ELEN_32 > and

Re: Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

2023-09-05 Thread Feng Wang
According to the doc, take“Mask(VECTOR_ELEN_32)     Var(riscv_vector_elen_flags)”as example, it just generates the OPTION_MASK_VECTOR_ELEN_32, will not generate MASK_VECTOR_ELEN_32 and TARGET_VECTOR_ELEN_32.  Do you want to use "MASK(name) Var(other_flags)" to generate the MASK and TARGET Macro