e.zh...@rivai.ai
CC: gcc-patches; richard.sandiford
Subject: Re: Re: [PATCH V2] VECT: Support loop len control on EXTRACT_LAST
vectorization
On Thu, 10 Aug 2023, juzhe.zh...@rivai.ai wrote:
> Hi, Richi.
>
> >> What inserts the required LC SSA PHI in that case?
>
> Here is the flow how GCC i
as ECF_CONST, it can definitely work
> but such pattern is redundant since we can reuse 'VEC_EXTRACT' pattern which
> is suitable for us.
Hmm, I think VEC_EXTRACT and VEC_SET should be ECF_CONST. Maybe the
GIMPLE ISEL
comments do not match the implementation, but then
roach I think is adding IFN_EXTRACT_LAST_LEN as Richard
said, and make IFN_EXTRACT_LAST_LEN as ECF_CONST, it can definitely work
but such pattern is redundant since we can reuse 'VEC_EXTRACT' pattern which is
suitable for us.
Thanks.
juzhe.zh...@rivai.ai
From: Richard Biener
On Thu, 10 Aug 2023, juzhe.zh...@rivai.ai wrote:
> >> I guess as a temporary thing your approach is OK but we shouldn't
> >> add these as part of new code - it's supposed to handle legacy
> >> cases that we didn't fixup yet.
>
> Do you mean we need to fix LC SSA PHI flow so that we don't need to
>> I guess as a temporary thing your approach is OK but we shouldn't
>> add these as part of new code - it's supposed to handle legacy
>> cases that we didn't fixup yet.
Do you mean we need to fix LC SSA PHI flow so that we don't need to
set vinfo->any_known_not_updated_vssa = true ?
After it's
Hi, Richi. Thanks so much for the review.
>> You should always manually update things. Did you verify the mask
>>case is handled by this?
When we enable LEN as loop control. The only mask case will be the condition
mask case.
Consider this following case:
int __attribute__ ((noinline, noclon
