Re: Re: [PATCH] RISC-V: Switch RVV cost model to generic vector cost model

2024-01-10 Thread 钟居哲
>> (1) Fall back to the generic cost model if the tune model didn't >> (specify one, i.e. make sure we always use the generic cost >> ( model rather than the default one. >> ((2) Change this generic (fallback) cost model so we don't have >> (regressions on the current trunk, as it's now always used

Re: Re: [PATCH] RISC-V: Switch RVV cost model to generic vector cost model

2024-01-10 Thread 钟居哲
Current generic cost model makes dynamic-lmul2-7.c generate inferior codegen. I found if I tweak the cost a little bit then dynamic-lmul2-7.c codegen can be recovered. However, it makes other tests failed It's complicated story So, I'd rather set it as default cost and switch to it. Then

Re: Re: [PATCH] RISC-V: Switch RVV cost model to generic vector cost model

2024-01-10 Thread 钟居哲
I need to add these costs for segment load/stores: /* Generic costs for VLA vector operations. */ static const scalable_vector_cost generic_vla_vector_cost = { { 1, /* int_stmt_cost */ 1, /* fp_stmt_cost */ 1, /* gather_load_cost */ 1, /* scatter_store_cost */ 1, /* vec_

Re: Re: [PATCH] RISC-V: Switch RVV cost model to generic vector cost model

2024-01-10 Thread 钟居哲
>> So is the idea here to just revert the values to the defaults for now >> and change them again soon? And not to keep this as another default >> and add others? My idea is to revert default for now. Then we can refine the cost gradually. >> I'm a bit confused here :) How does this help? Can'