Re: Re: [PATCH] RISC-V: Support LEN_FOLD_EXTRACT_LAST auto-vectorization

2023-08-24 Thread 钟居哲
>> The use_real_merge just appeared odd to me here because there is >> nothing to merge. But in the end it's just to omit the vundef operand >> so good for now. There is an increasing number of opportunities to >> refactor in riscv-v.cc, though ;) I think we can change use_real_merge into use_du

Re: Re: [PATCH] RISC-V: Support LEN_FOLD_EXTRACT_LAST auto-vectorization

2023-08-24 Thread 钟居哲
>> Why is that necessary? Just for the popcount I presume? >> Can't we rather have a new case for a scalar destination? I find >> the code a bit misleading now as we check m_dest_mode and then not >> use it. I am gonna fix it in V2. >> The rest looks good to me. Note that my machine crashed w