Ok. Just sent V2. I will adjust comment and send V3 again :)
juzhe.zh...@rivai.ai
From: Robin Dapp
Date: 2023-06-20 16:55
To: juzhe.zh...@rivai.ai; gcc-patches
CC: rdapp.gcc; kito.cheng; Kito.cheng; palmer; palmer; jeffreyalaw
Subject: Re: [PATCH] RISC-V: Optimize codegen of VLA SLP
> +
Hi, Robin. Can you give me more details of the comments:
What about:
/* As NPATTERNS is always a power of two, we can optimize codegen of
VLA const vector according to this feature. */
Is this comment Ok ? You know I am always struggle with adding an English
comment or description.
Tha
Hi, Robin.
>> Actually no assert necessary, just a comment like:
>> /* As NPATTERNS is always a power of two, we can ..." */
Ok.
>> My immediate idea would have been to fall back to the first
>> approach, i.e. create the "0x00030002..." constant
>>and then
>> vid.v v4
vand.vi v4, v4, -4
>
