Re: Re: [OpenACC 4/11] C FE changes

2015-10-23 Thread Jakub Jelinek
On Fri, Oct 23, 2015 at 10:31:55PM +0200, Jakub Jelinek wrote: > Doesn't this mean that you happily parse > gang (static: * abc) > or > gang (static:*num:1) > etc.? I'd say the comma should be non-optional (i.e. either accept > CPP_COMMA, or CPP_CLOSE_PARENT, but nothing else) in that case (at lea

Re: Re: [OpenACC 4/11] C FE changes

2015-10-23 Thread Jakub Jelinek
On Fri, Oct 23, 2015 at 01:17:07PM -0700, Cesar Philippidis wrote: > Good idea, thanks. This patch also corrects the problems parsing weird > combinations of num, static and length arguments that you mentioned > elsewhere. > > Is this OK for trunk? I'd strongly prefer to see always patches accomp

Re: Re: [OpenACC 4/11] C FE changes

2015-10-23 Thread Cesar Philippidis
On 10/22/2015 01:22 AM, Jakub Jelinek wrote: > On Wed, Oct 21, 2015 at 03:16:20PM -0400, Nathan Sidwell wrote: >> 2015-10-20 Cesar Philippidis >> Thomas Schwinge >> James Norris >> Joseph Myers >> Julian Brown >> >> * c-parser.c (c_parser_oacc_sha