Re: Rb tree node recycling patch

2014-01-09 Thread Paolo Carlini
Hi > Could you point me to the bugzilla entry you are mentioning ? libstdc++/29988 Thanks, Paolo

Re: Rb tree node recycling patch

2014-01-09 Thread François Dumont
On 01/08/2014 02:34 PM, Paolo Carlini wrote: Hi, On 12/27/2013 07:30 PM, François Dumont wrote: Note that this patch contains also a cleanup of a useless template parameter _Is_pod_comparator on _Rb_tree_impl. The useless parameter is a remnant of an attempt at exploiting the EBO for _Rb_tree_

Re: Rb tree node recycling patch

2014-01-08 Thread Paolo Carlini
On 01/08/2014 02:34 PM, Paolo Carlini wrote: Hi, On 12/27/2013 07:30 PM, François Dumont wrote: Note that this patch contains also a cleanup of a useless template parameter _Is_pod_comparator on _Rb_tree_impl. The useless parameter is a remnant of an attempt at exploiting the EBO for _Rb_tree_

Re: Rb tree node recycling patch

2014-01-08 Thread Paolo Carlini
Hi, On 12/27/2013 07:30 PM, François Dumont wrote: Note that this patch contains also a cleanup of a useless template parameter _Is_pod_comparator on _Rb_tree_impl. The useless parameter is a remnant of an attempt at exploiting the EBO for _Rb_tree_impl. At some point Benjamin got a patch from

Re: Rb tree node recycling patch

2014-01-08 Thread Jonathan Wakely
On 27 December 2013 18:30, François Dumont wrote: > Hi > > Here is a patch to add recycling of Rb tree nodes when possible. The change looks good, but it is not a bug fix, so I don't think it's suitable for Stage 3. Please re-submit this after 4.9 is released when we are in Stage 1 again, tha

Re: Rb tree node recycling patch

2014-01-03 Thread François Dumont
Thanks for your feedback. I considered my patch enough tested because it impacts basic operations on the Rb tree containers. There are also a number of tests that are normally dedicated to exception safety but that has the advantage of challenging numerous containers operations in a generi

Re: Rb tree node recycling patch

2014-01-03 Thread Christopher Jefferson
Personally, I consider the testing insufficent, although the testing was already insufficient! Note that this is my opinion, don't assume I talk for all of libstdc++! After I broke std::nth_element in 4.8.2 (woops), I am of the view that the libstdc++ testsuite is defficient -- many code paths are