Re: RFD: Buffer handling for ASM_GENERATE_INTERNAL_LABEL

2016-11-02 Thread Bernd Schmidt
On 10/29/2016 04:17 PM, Trevor Saunders wrote: So actually a thing I've wanted to do for a while is add a long string building class to generate asm into that would use a set of buffers adding new ones when the space is needed. So that would look something like I'd do something a little simpl

Re: RFD: Buffer handling for ASM_GENERATE_INTERNAL_LABEL

2016-10-29 Thread Bernd Edlinger
Hi, > Sadly, there's a bigger issue here. Namely that the caller and the > definition of ASM_GENERATE_INTERNAL_LABEL both can include arbitrary > length text into the label name. Furthermore, the buffer is allocated > in the caller's context. It's a terrible API. Yes. Even ASM_FORMAT_PRIVAT

Re: RFD: Buffer handling for ASM_GENERATE_INTERNAL_LABEL

2016-10-29 Thread Trevor Saunders
On Fri, Oct 28, 2016 at 09:42:10PM -0600, Jeff Law wrote: > > Consider this definition of ASM_GENERATE_INTERNAL_LABEL (from sp64-elf.h): > > #undef ASM_GENERATE_INTERNAL_LABEL > #define ASM_GENERATE_INTERNAL_LABEL(LABEL,PREFIX,NUM) \ > sprintf ((LABEL), "*.L%s%ld", (PREFIX), (long)(NUM)) >