Re: RFC: c-common PATCHes to fully fold warning function arguments

2015-12-02 Thread Joseph Myers
On Wed, 2 Dec 2015, Jason Merrill wrote: > > The new file needs copyright and license notices. > > So it does, thanks. > > > > The second patch defines fold_for_warn to call c_fully_fold and uses it in > > > places in the warn_* functions that want to know if the operand has a > > > constant > >

Re: RFC: c-common PATCHes to fully fold warning function arguments

2015-12-02 Thread Jason Merrill
On 12/02/2015 12:50 PM, Joseph Myers wrote: On Wed, 2 Dec 2015, Jason Merrill wrote: As richi pointed out in another thread, calling fold in warn_tautological_cmp is problematic because fold expects operands of its argument to have already been folded; we really need to call *_fully_fold. The

Re: RFC: c-common PATCHes to fully fold warning function arguments

2015-12-02 Thread Joseph Myers
On Wed, 2 Dec 2015, Jason Merrill wrote: > As richi pointed out in another thread, calling fold in warn_tautological_cmp > is problematic because fold expects operands of its argument to have already > been folded; we really need to call *_fully_fold. > > The first patch moves c_fully_fold into t