Re: RFA: RL78: Add missing instruction patterns

2014-02-28 Thread DJ Delorie
> * config/rl78/rl78-real.md (cbranchsi4_real_signed): Add > anti-cacnonical alternatives. > (negandhi3_real): New pattern. > * config/rl78/rl78-virt.md (negandhi3_virt): New pattern. These are fine, although I don't know why gcc would require a negandhi3 pattern...

Re: RFA: RL78: Add missing instruction patterns

2014-02-18 Thread nick clifton
Hi DJ, I'm OK with adding patterns in general, but I wonder if gcc would produce better code if they were split into QImode ops earlier? Probably. In fact I double checked and I can no longer find the tests that triggered the need for the new "andhi3" and "xorhi3" patterns, so the revised p

Re: RFA: RL78: Add missing instruction patterns

2014-02-14 Thread DJ Delorie
I'm OK with adding patterns in general, but I wonder if gcc would produce better code if they were split into QImode ops earlier? + [(set (match_operand:HI 0 "register_operand" "=Av") + (and:HI (match_operand:HI 1 "register_operand" "0") + (match_operand:HI 2 "immed