On Tue, Apr 9, 2013 at 6:24 PM, Joern Rennecke
wrote:
> Quoting Richard Biener :
>
>> I don't see that. It's merely a complication of optimal handling of
>> a * b +- c * d vs. just a * b +- c. The pass does simple pattern matching
>> only, not doing a global optimal transform, so adding another
Quoting Richard Biener :
I don't see that. It's merely a complication of optimal handling of
a * b +- c * d vs. just a * b +- c. The pass does simple pattern matching
only, not doing a global optimal transform, so adding another special-case
is reasonable. Special-casing just for single-use 2
On Tue, Apr 9, 2013 at 4:53 PM, Joern Rennecke
wrote:
> Quoting Richard Biener :
>
> Oops, I missed your final comment when I wrote my first reply.
>
>
>> I fail to see why you need two passes for this rather than considering the
>> case that the immediate use stmt of the multiplication we start f
Quoting Richard Biener :
Oops, I missed your final comment when I wrote my first reply.
I fail to see why you need two passes for this rather than considering the
case that the immediate use stmt of the multiplication we start from
combines another multiplication with a MINUS_EXPR. That is ...
On Tue, Apr 9, 2013 at 1:25 PM, Joern Rennecke
wrote:
> Quoting Richard Biener :
>
>> On Mon, Apr 8, 2013 at 5:10 PM, Joern Rennecke
>> wrote:
>>>
>>> This is basically the same patch as attached to the PR, except that I
>>> have changed the goto-loop into a do-while loop with a new comment;
>>>
Quoting Richard Biener :
On Mon, Apr 8, 2013 at 5:10 PM, Joern Rennecke
wrote:
This is basically the same patch as attached to the PR, except that I
have changed the goto-loop into a do-while loop with a new comment;
this caused the need for a lot of reformatting.
Can you please include a te
On Mon, Apr 8, 2013 at 5:10 PM, Joern Rennecke
wrote:
> This is basically the same patch as attached to the PR, except that I
> have changed the goto-loop into a do-while loop with a new comment;
> this caused the need for a lot of reformatting.
Can you please include a testcase that shows the ef