Re: PowerPC64 ELFv1 -fpatchable-function-entry

2021-05-18 Thread Alan Modra via Gcc-patches
On Fri, May 07, 2021 at 07:24:02PM -0500, Segher Boessenkool wrote: > Looks good with those things tweaked. Except that the patch chose the wrong section to emit the label, because the decl is wrong. But of course I was using the same decl as used in existing SHF_LINK_ORDER support, so it was alr

Re: PowerPC64 ELFv1 -fpatchable-function-entry

2021-05-07 Thread Segher Boessenkool
Hi! On Fri, May 07, 2021 at 12:19:50PM +0930, Alan Modra wrote: > --- a/gcc/varasm.c > +++ b/gcc/varasm.c > @@ -6866,6 +6866,26 @@ default_elf_asm_named_section (const char *name, > unsigned int flags, >*f = '\0'; > } > > + char func_label[256]; > + if (flags & SECTION_LINK_ORDER

Re: PowerPC64 ELFv1 -fpatchable-function-entry

2021-05-07 Thread Segher Boessenkool
On Fri, May 07, 2021 at 08:47:02AM -0500, will schmidt wrote: > On Fri, 2021-05-07 at 12:19 +0930, Alan Modra via Gcc-patches wrote: > > --- a/gcc/varasm.c > > +++ b/gcc/varasm.c > > @@ -6866,6 +6866,26 @@ default_elf_asm_named_section (const char > > *name, unsigned int flags, > >*f = '\0'

Re: PowerPC64 ELFv1 -fpatchable-function-entry

2021-05-07 Thread will schmidt via Gcc-patches
On Fri, 2021-05-07 at 12:19 +0930, Alan Modra via Gcc-patches wrote: > On PowerPC64 ELFv1 function symbols are defined on function > descriptors in an .opd section rather than in the function code. > .opd is not split up by the PowerPC64 backend for comdat groups or > other situations where per-fun