Hi David,
Please find my revised patch attached. You should find all items addressed. I
have bootstrapped and rerun the testsuite (gcc and g++ only). Also, you
should have seen my legal paperwork go in.
1) The commit message has been updated to reflect the nomenclature in the
testsuite, as well
On Wed, 2021-02-17 at 23:18 +, brian.sobulefsky wrote:
> Hi David,
>
> I'm sorry but I wanted to get this out to you. To clarify, I had a
> statement of the form:
>
> end_offset <= covering_field->field_decl.bit_offset->int_cst.val[0]
> covering_field->decl_common.size->int_cst.val[0] - 1
Hi David,
I'm sorry but I wanted to get this out to you. To clarify, I had a statement of
the form:
end_offset <= covering_field->field_decl.bit_offset->int_cst.val[0]
covering_field->decl_common.size->int_cst.val[0] - 1;
(Sorry if my email is clobbering the angle brackets). I have replaced
David,
Two items I needs answered to get you the patch.
1) The get_field_at_bit_offset function is static in region.cc, so I cannot use
it outside of the file (you want me to use it in store.cc) without updating
that definition to extern. I am assuming you want this.
2) I am updating my direct
Hi, answers below. Note, do you want my resubmitted patch to be with
commit --amend, and therefore relative to "real" commits in the history,
or do you want me to chain it onto the last submission?
I have already sent to assign at gnu for the form.
I will update the commit message to call it s3 n
On Wed, 2021-02-10 at 19:42 +, brian.sobulefsky wrote:
Hi Brian
Thanks for the patch.
The patch is large enough to count as legally significant; I've sent
you information on copyright assignment separately; the patch can't be
committed until that paperwork is in place.
In the meantime, I've
I apologize. I left a dangling space in the patch. I am guessing
that this is against whitespace policy. I had actually corrected
it but forgot to add the file to the commit. Please see the
attached.commit a9b60f36b499463b49095f28ce8053f6387c506d
Author: Brian Sobulefsky
Date: Tue Feb 9 16:25:43
