Re: PR tree-optimization/57337

2013-05-28 Thread Easwaran Raman
On Tue, May 28, 2013 at 4:11 AM, Richard Biener wrote: > On Mon, May 27, 2013 at 10:20 AM, Richard Biener > wrote: >> On Sun, May 26, 2013 at 5:53 AM, Easwaran Raman wrote: >>> On Sat, May 25, 2013 at 4:46 AM, Richard Biener >>> wrote: Easwaran Raman wrote: >In that case, if my i

Re: PR tree-optimization/57337

2013-05-28 Thread Richard Biener
On Mon, May 27, 2013 at 10:20 AM, Richard Biener wrote: > On Sun, May 26, 2013 at 5:53 AM, Easwaran Raman wrote: >> On Sat, May 25, 2013 at 4:46 AM, Richard Biener >> wrote: >>> Easwaran Raman wrote: >>> In that case, if my insert_stmt immediately follows dep_stmt and both have the same

Re: PR tree-optimization/57337

2013-05-27 Thread Richard Biener
On Sun, May 26, 2013 at 5:53 AM, Easwaran Raman wrote: > On Sat, May 25, 2013 at 4:46 AM, Richard Biener > wrote: >> Easwaran Raman wrote: >> >>>In that case, if my insert_stmt immediately follows dep_stmt and both >>>have the same UID, not_dominated_by would return true and I will end >>>up upd

Re: PR tree-optimization/57337

2013-05-25 Thread Easwaran Raman
On Sat, May 25, 2013 at 4:46 AM, Richard Biener wrote: > Easwaran Raman wrote: > >>In that case, if my insert_stmt immediately follows dep_stmt and both >>have the same UID, not_dominated_by would return true and I will end >>up updating insert_stmt to dep_stmt which is wrong. > > But there shoul

Re: PR tree-optimization/57337

2013-05-25 Thread Richard Biener
Easwaran Raman wrote: >In that case, if my insert_stmt immediately follows dep_stmt and both >have the same UID, not_dominated_by would return true and I will end >up updating insert_stmt to dep_stmt which is wrong. But there should be a safe default answer for Equal uids. Unless we are asking d

Re: PR tree-optimization/57337

2013-05-24 Thread Easwaran Raman
In that case, if my insert_stmt immediately follows dep_stmt and both have the same UID, not_dominated_by would return true and I will end up updating insert_stmt to dep_stmt which is wrong. - Easwaran On Fri, May 24, 2013 at 1:07 AM, Richard Biener wrote: > On Thu, May 23, 2013 at 7:26 PM, Easw

Re: PR tree-optimization/57337

2013-05-24 Thread Richard Biener
On Thu, May 23, 2013 at 7:26 PM, Easwaran Raman wrote: > This addresses the case where UID alone is not sufficient to figure > out which statement appears earlier in a BB. Bootstraps and no test > regressions in x86_64 on linux. Ok for trunk? Why not simply conservatively use gimple_uid (a) <= g