On 10/24/2012 01:54 PM, Manuel López-Ibáñez wrote:
/* Add a note with text GMSGID and with LOCATION to the diagnostic CONTEXT. */
Sure.
Actually, I don't know why I call it "attach". diagnostic_add_note()
or diagnostic_print_note() seems clearer. What do you think?
How about "append"?
Jas
What about?
/* Add a note with text GMSGID and with LOCATION to the diagnostic CONTEXT. */
Actually, I don't know why I call it "attach". diagnostic_add_note()
or diagnostic_print_note() seems clearer. What do you think?
Cheers,
Manuel.
On 24 October 2012 19:27, Jason Merrill wrote:
> Agree
Agreed. OK with the comment added.
Jason
I am not a maintainer so the below are just some casual comments of
mine. I am deferring to the maintainers for a real review.
Manuel López-Ibáñez writes:
> gcc/
> * tree-diagnostic.c (maybe_unwind_expanded_macro_loc):
> Use diagnostic_attach_note.
> * diagnostic.c (diagnostic
On 18 October 2012 00:24, Gabriel Dos Reis
wrote:
> On Wed, Oct 17, 2012 at 6:26 AM, Manuel López-Ibáñez
> wrote:
>> On 17 October 2012 11:55, Dodji Seketeli wrote:
>>> Hello Manuel,
>>>
>>> Let's CC Gaby on this one as well.
>>>
>>> Manuel López-Ibáñez writes:
>>>
The problem is that the
On Wed, Oct 17, 2012 at 6:26 AM, Manuel López-Ibáñez
wrote:
> On 17 October 2012 11:55, Dodji Seketeli wrote:
>> Hello Manuel,
>>
>> Let's CC Gaby on this one as well.
>>
>> Manuel López-Ibáñez writes:
>>
>>> The problem is that the macro unwinder code is changing the original
>>> diagnostic typ
On 17 October 2012 11:55, Dodji Seketeli wrote:
> Hello Manuel,
>
> Let's CC Gaby on this one as well.
>
> Manuel López-Ibáñez writes:
>
>> The problem is that the macro unwinder code is changing the original
>> diagnostic type and not restoring it, so the code detecting that we
>> ICE fails to a
Hello Manuel,
Let's CC Gaby on this one as well.
Manuel López-Ibáñez writes:
> The problem is that the macro unwinder code is changing the original
> diagnostic type and not restoring it, so the code detecting that we
> ICE fails to abort, which triggers another ICE, and so on. But there
> is n
