Re: PR C++/58708 - string literal operator templates broken

2013-11-01 Thread Jason Merrill
OK. Jason

Re: PR C++/58708 - string literal operator templates broken

2013-10-31 Thread Jakub Jelinek
On Thu, Oct 31, 2013 at 08:34:55AM -0400, Ed Smith-Rowland wrote: > 2013-10-31 Edward Smith-Rowland <3dw...@verizon.net> > > PR c++/58708 > * parser.c (make_string_pack): Discover non-const type and size > of character and build parm pack with correct type and chars. > > gcc

Re: PR C++/58708 - string literal operator templates broken

2013-10-31 Thread Ed Smith-Rowland
On 10/25/2013 10:40 AM, Jakub Jelinek wrote: On Fri, Oct 25, 2013 at 10:29:41AM -0400, Ed Smith-Rowland wrote: 2013-10-25 Edward Smith-Rowland <3dw...@verizon.net> PR c++/58708 * parser.c (make_string_pack): Discover non-const type and size of character and build parm

Re: PR C++/58708 - string literal operator templates broken

2013-10-25 Thread Jakub Jelinek
On Fri, Oct 25, 2013 at 10:29:41AM -0400, Ed Smith-Rowland wrote: > 2013-10-25 Edward Smith-Rowland <3dw...@verizon.net> > > PR c++/58708 > * parser.c (make_string_pack): Discover non-const type and size > of character and build parm pack with correct type and chars. > > gcc

Re: PR C++/58708 - string literal operator templates broken

2013-10-25 Thread Paolo Carlini
On 10/25/2013 04:29 PM, Ed Smith-Rowland wrote: Here is one with necessary tools inlined. You still have a lot of redundant code... I'm not going to insist anyway. Paolo.

Re: PR C++/58708 - string literal operator templates broken

2013-10-25 Thread Ed Smith-Rowland
On 10/25/2013 10:01 AM, Paolo Carlini wrote: On 10/25/2013 03:46 PM, Ed Smith-Rowland wrote: On 10/25/2013 07:54 AM, Paolo Carlini wrote: On 10/25/2013 01:38 PM, Ed Smith-Rowland wrote: So, you also want a library testcase? Up to you: if you feel it would test something that the c++ front-end

Re: PR C++/58708 - string literal operator templates broken

2013-10-25 Thread Ed Smith-Rowland
On 10/25/2013 10:01 AM, Paolo Carlini wrote: On 10/25/2013 03:46 PM, Ed Smith-Rowland wrote: On 10/25/2013 07:54 AM, Paolo Carlini wrote: On 10/25/2013 01:38 PM, Ed Smith-Rowland wrote: So, you also want a library testcase? Up to you: if you feel it would test something that the c++ front-end

Re: PR C++/58708 - string literal operator templates broken

2013-10-25 Thread Paolo Carlini
On 10/25/2013 03:46 PM, Ed Smith-Rowland wrote: On 10/25/2013 07:54 AM, Paolo Carlini wrote: On 10/25/2013 01:38 PM, Ed Smith-Rowland wrote: So, you also want a library testcase? Up to you: if you feel it would test something that the c++ front-end testcase doesn't, why not. Paolo. I think

Re: PR C++/58708 - string literal operator templates broken

2013-10-25 Thread Ed Smith-Rowland
On 10/25/2013 07:54 AM, Paolo Carlini wrote: On 10/25/2013 01:38 PM, Ed Smith-Rowland wrote: So, you also want a library testcase? Up to you: if you feel it would test something that the c++ front-end testcase doesn't, why not. Paolo. I think this patch should be sufficient - no containers,

Re: PR C++/58708 - string literal operator templates broken

2013-10-25 Thread Paolo Carlini
On 10/25/2013 01:38 PM, Ed Smith-Rowland wrote: So, you also want a library testcase? Up to you: if you feel it would test something that the c++ front-end testcase doesn't, why not. Paolo.

Re: PR C++/58708 - string literal operator templates broken

2013-10-25 Thread Ed Smith-Rowland
On 10/25/2013 06:08 AM, Paolo Carlini wrote: Hi, On 10/18/2013 04:42 AM, Ed Smith-Rowland wrote: --- testsuite/g++.dg/cpp1y/pr58708.C (revision 0) +++ testsuite/g++.dg/cpp1y/pr58708.C(working copy) @@ -0,0 +1,70 @@ +// { dg-options -std=c++1y } + +#include +#include +#include +#include

Re: PR C++/58708 - string literal operator templates broken

2013-10-25 Thread Paolo Carlini
Hi, On 10/18/2013 04:42 AM, Ed Smith-Rowland wrote: --- testsuite/g++.dg/cpp1y/pr58708.C(revision 0) +++ testsuite/g++.dg/cpp1y/pr58708.C(working copy) @@ -0,0 +1,70 @@ +// { dg-options -std=c++1y } + +#include +#include +#include +#include are you sure you want these includes in a C

Re: PR C++/58708 - string literal operator templates broken

2013-10-18 Thread Paolo Carlini
On 10/18/2013 04:42 AM, Ed Smith-Rowland wrote: Here is a patch to correct the char type and the type, number of nontype parameter pack for user defined strng literal operator templates. Let's make sure Jason is in CC. Thanks! Paolo.