Re: PR 61084: Use widest_int in sparc_fold_builtin

2014-05-19 Thread Mike Stump
On May 19, 2014, at 12:27 AM, Richard Sandiford wrote: > Does anyone have any suggestions for a better name than "wide_int" though? Please, no. > The main property of wide_int is that it has a variable precision, whereas > widest_int and offset_int have constant precisions. Right, I'd clarify

Re: PR 61084: Use widest_int in sparc_fold_builtin

2014-05-19 Thread Richard Sandiford
Eric Botcazou writes: >> Well, I understood the distinction between wide_int and widest_int. >> I just didn't understand what pdist did. :-) >> >> The difference is documented (a bit verbosely) in wide-int.h. > > Yes, but not really why it's not correct to use wide_int for the computation > made

Re: PR 61084: Use widest_int in sparc_fold_builtin

2014-05-19 Thread Eric Botcazou
> Well, I understood the distinction between wide_int and widest_int. > I just didn't understand what pdist did. :-) > > The difference is documented (a bit verbosely) in wide-int.h. Yes, but not really why it's not correct to use wide_int for the computation made in pdist (and whether the use o

Re: PR 61084: Use widest_int in sparc_fold_builtin

2014-05-19 Thread Richard Sandiford
Eric Botcazou writes: >> This is the second part of PR 61084, which it seems I'd forgotten to post. >> pdist calculates a wide result from narrower inputs, so I should have >> used widest_int rather than wide_int. > > Is that documented? Because, if even you wide-int guys got it wrong... Well, I

Re: PR 61084: Use widest_int in sparc_fold_builtin

2014-05-16 Thread Eric Botcazou
> This is the second part of PR 61084, which it seems I'd forgotten to post. > pdist calculates a wide result from narrower inputs, so I should have > used widest_int rather than wide_int. Is that documented? Because, if even you wide-int guys got it wrong... > PR target/61084 > * co