Re: PR 60414: Patch proposal

2014-07-26 Thread Mikael Morin
Hello, thanks for your contribution. here are some comments about the patch: Le 21/07/2014 15:03, Andre Vehreschild a écrit : > diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog > index c33936b..cb01a13 100644 > --- a/gcc/fortran/ChangeLog > +++ b/gcc/fortran/ChangeLog Changelogs are pre

Re: PR 60414: Patch proposal

2014-07-21 Thread Dominique d'Humières
Le 21 juil. 2014 à 15:03, Andre Vehreschild a écrit : > Hi Dominique, > > thank you very much for your comments. I really appreciate them. ;-) > Unfortunately I am contracted only for a limited number of around 6 bugs. The > control on which bugs to pick is done by compiling a project and res

Re: PR 60414: Patch proposal

2014-07-19 Thread Andre Vehreschild
Hi FX, thank you for your help: ad 1) I thought the fixes to small for all the trouble to go through with a copyright assignment. But if it is needed, I will happily give copyright to the FSF and negotiate with my client all formal requirements. Unfortunately my English is not well enough to unde

Re: PR 60414: Patch proposal

2014-07-18 Thread FX
Hi Andre, and welcome aboard! The explanation you give is nice, your patch submission looks clean. Two things: 1. Do you have a copyright assignment on file with the FSF? See https://gcc.gnu.org/contribute.html 2. Normally, all GCC patch submissions should be accompanied by a statement say