Re: PPC libgcc IEEE128 soft-fp exception/rounding fixes

2016-02-29 Thread Bill Schmidt
Hi David, Please ignore this request. I had asked Paul to do this, but was confused that it relied on other patches that are not in GCC 5. My fault. Thanks, Bill On Mon, 2016-02-29 at 11:33 -0600, Paul E. Murphy wrote: > Hi David, > > Bill merged this into trunk last week. > > Is it okay to

Re: PPC libgcc IEEE128 soft-fp exception/rounding fixes

2016-02-29 Thread Paul E. Murphy
Hi David, Bill merged this into trunk last week. Is it okay to backport this to GCC 5? Thanks, Paul On 02/22/2016 05:51 PM, David Edelsohn wrote: > libgcc > * config/rs6000/sfp-machine.h: > (_FP_DECL_EX): Declare _fpsr as a union of u64 and double. > (FP_TRAPPING_EXCEPTIONS): Return a bitmask o

Re: PPC libgcc IEEE128 soft-fp exception/rounding fixes

2016-02-22 Thread David Edelsohn
libgcc * config/rs6000/sfp-machine.h: (_FP_DECL_EX): Declare _fpsr as a union of u64 and double. (FP_TRAPPING_EXCEPTIONS): Return a bitmask of trapping exceptions. (FP_INIT_ROUNDMODE): Read the fpscr instead of writing a mystery value. (FP_ROUNDMODE): Update the usage of _fpscr. Okay. Thanks, Dav

Re: PPC libgcc IEEE128 soft-fp exception/rounding fixes

2016-02-19 Thread Paul E. Murphy
On 02/17/2016 08:37 PM, Alan Modra wrote: >> +/* A set bit indicates an exception is trapping. */ >> +# define FP_TRAPPING_EXCEPTIONS ((_fpscr.i << 22) & FP_EX_ALL) > > why then a shift here, since FP_EX_* are defined as the actual > register bits? Oh, I see. FP_EX_* are the status bits, and

Re: PPC libgcc IEEE128 soft-fp exception/rounding fixes

2016-02-17 Thread Alan Modra
On Wed, Feb 17, 2016 at 05:40:01PM -0600, Paul E. Murphy wrote: > - FP_INIT_ROUNDMODE writes junk to the fpscr. I assume this should be > reading the fpscr and initializing the local rounding mode variable > declared via _FP_DECL_EX. Yeah, looks that way. > - FP_TRAPPING_EXCEPTIONS evaluates

Re: PPC libgcc IEEE128 soft-fp exception/rounding fixes

2016-02-17 Thread Joseph Myers
I have no comments on this patch beyond again suggesting that it would be desirable for some future float128 GCC patch to enable as many as possible of the x86 float128 tests (that is, tests of float128 anywhere in the GCC testsuite that currently are restricted to x86, x86_64 and ia64 targets o