Re: PING: [C++-11 PATCH] Trailing comma in enum

2011-10-30 Thread Ville Voutilainen
On 30 October 2011 12:17, Magnus Fromreide wrote: > Attached is a variation where maybe_warn_cpp0x is used. > Please note how my new pedwarn breaks the pattern in maybe_warn_cpp0x. Looks reasonable to me, but I'm not a maintainer. :) Jason?

Re: PING: [C++-11 PATCH] Trailing comma in enum

2011-10-30 Thread Magnus Fromreide
On Sat, 2011-10-29 at 20:48 +0300, Ville Voutilainen wrote: > >Could someone please review this? > > + if (cxx_dialect < cxx0x && !in_system_header) > + pedwarn (input_location, OPT_pedantic, > + "comma at end of enumerator list"); > > Why not use maybe_warn_cpp0

Re: PING: [C++-11 PATCH] Trailing comma in enum

2011-10-29 Thread Ville Voutilainen
>Could someone please review this? + if (cxx_dialect < cxx0x && !in_system_header) + pedwarn (input_location, OPT_pedantic, + "comma at end of enumerator list"); Why not use maybe_warn_cpp0x there?