Re: PATCH for c++/70639 (ICE-on-valid with -Wmisleading-indentation and switch)

2016-04-13 Thread Bernd Schmidt
On 04/13/2016 06:11 PM, David Malcolm wrote: Your approach encapsulates the logic for rejecting this situation within should_warn_for_misleading_indentation, rather than at the callers, which is arguably better for modularity (similar to how we already call it for "do", which is then always rejec

Re: PATCH for c++/70639 (ICE-on-valid with -Wmisleading-indentation and switch)

2016-04-13 Thread David Malcolm
On Wed, 2016-04-13 at 17:31 +0200, Marek Polacek wrote: > This is an ICE-on-valid-though-weirdo (TM) problem. We were trying > to warn > about misleading indentation for a switch statement, but > guard_tinfo_to_string > doesn't know what to do with RID_SWITCH and so a crash ensues. > Rather than