Re: PATCH: PR target/59363: [4.9 Regression] r203886 miscompiles git

2013-12-03 Thread H.J. Lu
On Tue, Dec 3, 2013 at 4:41 AM, Jan Hubicka wrote: >> Here is the updated patch. Tested on Linux/x86-64. It >> fixed git. OK to install? >> >> Thanks. >> >> -- >> H.J. >> --- >> gcc/ >> >> 2013-12-03 H.J. Lu >> >> PR target/59363 >> * config/i386/i386.c (emit_memset): Adjust destina

Re: PATCH: PR target/59363: [4.9 Regression] r203886 miscompiles git

2013-12-03 Thread Jan Hubicka
> Here is the updated patch. Tested on Linux/x86-64. It > fixed git. OK to install? > > Thanks. > > -- > H.J. > --- > gcc/ > > 2013-12-03 H.J. Lu > > PR target/59363 > * config/i386/i386.c (emit_memset): Adjust destination address > after gen_strset. > (expand_setmem_epi

Re: PATCH: PR target/59363: [4.9 Regression] r203886 miscompiles git

2013-12-03 Thread H.J. Lu
On Tue, Dec 3, 2013 at 12:45 AM, Michael Zolotukhin wrote: > Hi Uros, HJ, > > I checked expand_movmem_epilogue - it seemingly doesn't have such a > problem, so the patch is ok. > > We might want to add similar adjust_automodify_address_nv call to here as > well: > if (TARGET_64BIT) >

Re: PATCH: PR target/59363: [4.9 Regression] r203886 miscompiles git

2013-12-03 Thread Michael Zolotukhin
Hi Uros, HJ, I checked expand_movmem_epilogue - it seemingly doesn't have such a problem, so the patch is ok. We might want to add similar adjust_automodify_address_nv call to here as well: if (TARGET_64BIT) { dest = change_address (destmem, DImode, destptr); emit_

Re: PATCH: PR target/59363: [4.9 Regression] r203886 miscompiles git

2013-12-03 Thread Uros Bizjak
On Tue, Dec 3, 2013 at 2:05 AM, H.J. Lu wrote: > emit_memset fails to adjust destination address after gen_strset, which > leads to the wrong address in aliasing info. This patch fixes it. > Tested on Linux/x86-64. OK to install? > > 2013-12-03 H.J. Lu > > PR target/59363 >