Re: OpenMP 5.1: omp_display_env

2021-07-30 Thread Thomas Schwinge
Hi! On 2021-07-30T12:05:56+0200, I wrote: > On 2021-07-30T12:02:00+0200, Jakub Jelinek via Gcc-patches > wrote: >> On Fri, Jul 30, 2021 at 11:54:00AM +0200, Ulrich Drepper wrote: >>> On Fri, Jul 30, 2021 at 10:50 AM Jakub Jelinek wrote: >>> >>> > I think for now it would be better to guard the

Re: OpenMP 5.1: omp_display_env

2021-07-30 Thread Thomas Schwinge
Hi! On 2021-07-30T12:02:00+0200, Jakub Jelinek via Gcc-patches wrote: > On Fri, Jul 30, 2021 at 11:54:00AM +0200, Ulrich Drepper wrote: >> On Fri, Jul 30, 2021 at 10:50 AM Jakub Jelinek wrote: >> >> > I think for now it would be better to guard the omp_display_env_* >> > in fortran.c with #ifnd

Re: OpenMP 5.1: omp_display_env

2021-07-30 Thread Jakub Jelinek via Gcc-patches
On Fri, Jul 30, 2021 at 11:54:00AM +0200, Ulrich Drepper wrote: > On Fri, Jul 30, 2021 at 10:50 AM Jakub Jelinek wrote: > > > I think for now it would be better to guard the omp_display_env_* > > in fortran.c with #ifndef LIBGOMP_OFFLOADED_ONLY > > > > OK, easy enough. This compiles for me. Ok

Re: OpenMP 5.1: omp_display_env

2021-07-30 Thread Ulrich Drepper via Gcc-patches
On Fri, Jul 30, 2021 at 10:50 AM Jakub Jelinek wrote: > I think for now it would be better to guard the omp_display_env_* > in fortran.c with #ifndef LIBGOMP_OFFLOADED_ONLY > OK, easy enough. This compiles for me. diff --git a/libgomp/fortran.c b/libgomp/fortran.c index 76285d4376b..26ec8ce30

Re: OpenMP 5.1: omp_display_env

2021-07-30 Thread Jakub Jelinek via Gcc-patches
On Fri, Jul 30, 2021 at 10:43:01AM +0200, Ulrich Drepper wrote: > On Fri, Jul 30, 2021 at 9:50 AM Tobias Burnus > wrote: > > > this patch breaks offloading. The reason is that most code > > in env.c is enclosed in: > > > > Indeed, normally I test that configuration but my setup currently has a f

Re: OpenMP 5.1: omp_display_env

2021-07-30 Thread Ulrich Drepper via Gcc-patches
Hi, On Fri, Jul 30, 2021 at 9:50 AM Tobias Burnus wrote: > this patch breaks offloading. The reason is that most code > in env.c is enclosed in: > Indeed, normally I test that configuration but my setup currently has a few problems. Although the env vars aren't parsed for those targets it seem

Re: OpenMP 5.1: omp_display_env

2021-07-30 Thread Tobias Burnus
Hi Ulrich, hi all, this patch breaks offloading. The reason is that most code in env.c is enclosed in: #ifndef LIBGOMP_OFFLOADED_ONLY ... #endif /* LIBGOMP_OFFLOADED_ONLY */ But omp_display_env_ / omp_display_env_8_ in fortran.c is not. Hence, there is a link error for omp_display_env (e.g. nv

Re: OpenMP 5.1: omp_display_env

2021-07-27 Thread Jakub Jelinek via Gcc-patches
On Tue, Jul 27, 2021 at 04:26:22PM +0200, Ulrich Drepper via Gcc-patches wrote: > I know OpenMP 5.1 is not really a focus yet but adding this new interface > should not be problematic. I stumbled across this part of the spec and the > functionality is really already mostly there in the form of > O