Re: [PATCH v3] Re: OpenMP: Generate SIMD clones for functions with "declare target"

2022-10-27 Thread Sandra Loosemore
On 10/27/22 04:09, Thomas Schwinge wrote: Hi! On 2022-10-26T20:27:19-0600, Sandra Loosemore wrote: One of my test cases examines the .s output to make sure that the clones are emitted as local symbols and not global. I have not been able to find the symbol linkage information in any of the du

Re: [PATCH v3] Re: OpenMP: Generate SIMD clones for functions with "declare target"

2022-10-27 Thread Thomas Schwinge
Hi! On 2022-10-26T20:27:19-0600, Sandra Loosemore wrote: > On 10/20/22 08:07, Jakub Jelinek wrote: >> Thus, IMHO it is exactly the pass_omp_simd_clone pass where you want to >> implement this auto-simdization discovery, guarded with >> #ifdef ACCEL_COMPILER and the new option (which means it will

Re: [PATCH v3] Re: OpenMP: Generate SIMD clones for functions with "declare target"

2022-10-26 Thread Sandra Loosemore
On 10/20/22 08:07, Jakub Jelinek wrote: Thus, IMHO it is exactly the pass_omp_simd_clone pass where you want to implement this auto-simdization discovery, guarded with #ifdef ACCEL_COMPILER and the new option (which means it will be done only for gcn and not on the host right now). I'm running

Re: [PATCH v3] Re: OpenMP: Generate SIMD clones for functions with "declare target"

2022-10-20 Thread Jakub Jelinek via Gcc-patches
On Sun, Oct 16, 2022 at 07:23:05PM -0600, Sandra Loosemore wrote: > My sense is that the first approach would be more straightforward than the > second one, and I am willing to continue to work on that. However, I think > I need some direction to get started, as I presently know nothing about > cg

Re: [PATCH v3] Re: OpenMP: Generate SIMD clones for functions with "declare target"

2022-10-16 Thread Sandra Loosemore
On 9/30/22 04:37, Jakub Jelinek wrote: We've discussed this at Cauldron. Especially for this patch, but less urgently for explicit declare simd on non-exported functions (less urgently just because people don't mark everything declare simd usually) solving the above is essential. I don't say i

Re: [PATCH v2] Re: OpenMP: Generate SIMD clones for functions with "declare target"

2022-09-30 Thread Jakub Jelinek via Gcc-patches
On Wed, Sep 21, 2022 at 09:17:18PM -0600, Sandra Loosemore wrote: > On 9/14/22 12:12, Jakub Jelinek wrote: > > > If it is pure optimization thing and purely keyed on the definition, > > all the simd clones should be local to the TU, never exported from it. > > OK, here is a revised patch that add

[PATCH v2] Re: OpenMP: Generate SIMD clones for functions with "declare target"

2022-09-21 Thread Sandra Loosemore
On 9/14/22 12:12, Jakub Jelinek wrote: If it is pure optimization thing and purely keyed on the definition, all the simd clones should be local to the TU, never exported from it. OK, here is a revised patch that addresses that. x86_64 target also generates a different set of clones for funct

Re: OpenMP: Generate SIMD clones for functions with "declare target"

2022-09-14 Thread Thomas Schwinge
Hi Sandra! Commenting on just one single item: On 2022-09-14T11:32:11-0600, Sandra Loosemore wrote: > --- a/gcc/omp-simd-clone.cc > +++ b/gcc/omp-simd-clone.cc > void > expand_simd_clones (struct cgraph_node *node) > { > - tree attr = lookup_attribute ("omp declare simd", > -

Re: OpenMP: Generate SIMD clones for functions with "declare target"

2022-09-14 Thread Jakub Jelinek via Gcc-patches
On Wed, Sep 14, 2022 at 11:32:11AM -0600, Sandra Loosemore wrote: > This patch is part of the ongoing effort to find more SIMD optimization > opportunities in OpenMP code. Here we are looking for functions that have > the "omp declare target" attribute that are also suitable candidates for > autom