Re: Next set of OpenACC changes: Fortran

2015-05-06 Thread James Norris
Tobias, First, thank you for taking the time to review the patch. Second, thank you for providing the comments. It appears all of the comments need to be acted upon in some manner. Thanks! On 05/05/2015 05:01 AM, Tobias Burnus wrote: Thomas Schwinge wrote: In follow-up messages, I'll be post

Re: Next set of OpenACC changes: Fortran

2015-05-05 Thread Bernhard Reutner-Fischer
On 5 May 2015 at 10:58, Thomas Schwinge wrote: > Hi! +/* Node in the linked list used for storing !$oacc declare constructs. */ The clause is called $ACC declare, isn't it? > + for (oc = new_oc; oc; oc = oc->next) > +{ > + c = oc->clauses; > + for (n = c->lists[OMP_LIST_MAP];

Re: Next set of OpenACC changes: Fortran

2015-05-05 Thread Tobias Burnus
Thomas Schwinge wrote: > In follow-up messages, I'll be posting the separated parts (for easier > review) of a next set of OpenACC changes that we'd like to commit. > ChangeLog updates not yet written; will do that before commit, obviously. Still, it would have been nice if you had given an overvi