Re: New OpenACC pass and Target Hook

2015-09-30 Thread Bernd Schmidt
For avoidance of doubt, is this approval, or 'LGTM, but needs Jakub's approval'? Go ahead and commit. Bernd

Re: New OpenACC pass and Target Hook

2015-09-30 Thread Nathan Sidwell
On 09/30/15 11:52, Nathan Sidwell wrote: For avoidance of doubt, is this approval, or 'LGTM, but needs Jakub's approval'? Just noticed unnecessary white space change that patch contained. Updated here. nathan 2015-09-30 Nathan Sidwell Cesar Philippidis gcc/ * config/nvptx/nvptx

Re: New OpenACC pass and Target Hook

2015-09-30 Thread Nathan Sidwell
On 09/30/15 09:27, Bernd Schmidt wrote: The function name and/or comment should mention OpenACC, it could be confusing otherwise. Done (both) I don't know what style to use for unused args now that we have C++. I'm fine with this, and it presumably will be changed anyway. Correct. I fee

Re: New OpenACC pass and Target Hook

2015-09-30 Thread Bernd Schmidt
On 09/29/2015 08:36 PM, Nathan Sidwell wrote: This patch implements an openacc device-specific lowering pass, and an openacc target hook for validating compute dimensions. The pass 'oaccdevlow' is inserted early after LTO readback. It is active for offloaded openacc functions, and openacc routi