Re: Move DECL_VINDEX and DECL_SAVED_TREE into function_decl

2014-07-10 Thread Jan Hubicka
> I'm seeing ICEs: »tree check: expected function_decl, have type_decl in > fold_checksum_tree, at fold-const.c:14861«. Is the following the correct > fix, or should this be done differently? No, it seems fine to me. I added it to my local patch, thanks! Honza > > --- gcc/fold-const.c > +++ gcc

Re: Move DECL_VINDEX and DECL_SAVED_TREE into function_decl

2014-07-10 Thread Richard Biener
On Thu, Jul 10, 2014 at 11:50 AM, Thomas Schwinge wrote: > Hi! > > On Mon, 23 Jun 2014 22:25:41 +0200, Jan Hubicka wrote: >> this patch makes DECL_VINDEX and DECL_SAVED_TREE to be FUNCTION_DECL only. > >> Bootstrapped/regtested x86_64-linux, OK? > > ... without --enable-checking=fold. ;-P > >>

Re: Move DECL_VINDEX and DECL_SAVED_TREE into function_decl

2014-07-10 Thread Thomas Schwinge
Hi! On Mon, 23 Jun 2014 22:25:41 +0200, Jan Hubicka wrote: > this patch makes DECL_VINDEX and DECL_SAVED_TREE to be FUNCTION_DECL only. > Bootstrapped/regtested x86_64-linux, OK? ... without --enable-checking=fold. ;-P > * class.c (check_methods, create_vtable_ptr, determine_key_method,

Re: Move DECL_VINDEX and DECL_SAVED_TREE into function_decl

2014-06-24 Thread Jan Hubicka
> On 06/24/2014 02:18 PM, Jan Hubicka wrote: > >>On 06/23/2014 04:25 PM, Jan Hubicka wrote: > >>> * class.c (check_methods, create_vtable_ptr, determine_key_method, > >>> add_vcall_offset_vtbl_entries_1): Guard VINDEX checks by FUNCTION_DECL > >>> check. > >> > >>These changes are unnecessary:

Re: Move DECL_VINDEX and DECL_SAVED_TREE into function_decl

2014-06-24 Thread Jason Merrill
On 06/24/2014 02:18 PM, Jan Hubicka wrote: On 06/23/2014 04:25 PM, Jan Hubicka wrote: * class.c (check_methods, create_vtable_ptr, determine_key_method, add_vcall_offset_vtbl_entries_1): Guard VINDEX checks by FUNCTION_DECL check. These changes are unnecessary: TYPE_METHODS is

Re: Move DECL_VINDEX and DECL_SAVED_TREE into function_decl

2014-06-24 Thread Jan Hubicka
> On 06/23/2014 04:25 PM, Jan Hubicka wrote: > > * class.c (check_methods, create_vtable_ptr, determine_key_method, > > add_vcall_offset_vtbl_entries_1): Guard VINDEX checks by FUNCTION_DECL > > check. > > These changes are unnecessary: TYPE_METHODS is a list of functions. I just double

Re: Move DECL_VINDEX and DECL_SAVED_TREE into function_decl

2014-06-24 Thread Jason Merrill
On 06/23/2014 04:25 PM, Jan Hubicka wrote: * class.c (check_methods, create_vtable_ptr, determine_key_method, add_vcall_offset_vtbl_entries_1): Guard VINDEX checks by FUNCTION_DECL check. These changes are unnecessary: TYPE_METHODS is a list of functions. The rest of the patch