Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-04-20 Thread Gerald Pfeifer
On Mon, 20 Apr 2015, Thomas Schwinge wrote: > Gerald, is it OK to commit the following to update GCC 5 changes' »New > Languages and Language specific improvements« section? Sure thing. Gerald

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-04-20 Thread Thomas Schwinge
Hi! On Thu, 15 Jan 2015 21:20:07 +0100, I wrote: > In r219682, I have committed to trunk our current set of OpenACC changes, > which we had prepared on gomp-4_0-branch. Thanks to everyone who has > been contributing! > > Note that this is an experimental feature, incomplete, and subject to > cha

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-02-24 Thread Julian Brown
Hi, On Wed, 4 Feb 2015 15:05:45 + Julian Brown wrote: > The major changes are: > > * The removal of the OpenACC-specific plugin hooks open_device, > close_device, set_device_num and get_device_num. The functionality > has been moved into the init/fini hooks (for the first two) or moved

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-02-18 Thread Ilya Verbin
On Wed, Feb 04, 2015 at 15:05:45 +, Julian Brown wrote: > This (WIP) patch is based on top of a version of your patch that I > merged to our internal branch: that's still the easiest way for me to > test the PTX backend (with unloading support) at present, and it passes > libgomp testing that w

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-02-17 Thread Thomas Schwinge
Hi! On Thu, 15 Jan 2015 21:20:07 +0100, I wrote: > In r219682, I have committed to trunk our current set of OpenACC changes, > which we had prepared on gomp-4_0-branch. This whole file is scheduled to go away: the routines are to be replaced by builtins which are expanded in the nvptx backend, bu

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-02-04 Thread Julian Brown
On Tue, 3 Feb 2015 23:01:04 +0300 Ilya Verbin wrote: > On 03 Feb 13:00, Julian Brown wrote: > > On Tue, 3 Feb 2015 14:28:44 +0300 > > Ilya Verbin wrote: > > > On 27 Jan 14:07, Julian Brown wrote: > > > > On Mon, 26 Jan 2015 17:34:26 +0300 > > > > Ilya Verbin wrote: > > > > > Here is my current

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-02-03 Thread Ilya Verbin
On 03 Feb 13:00, Julian Brown wrote: > On Tue, 3 Feb 2015 14:28:44 +0300 > Ilya Verbin wrote: > > On 27 Jan 14:07, Julian Brown wrote: > > > On Mon, 26 Jan 2015 17:34:26 +0300 > > > Ilya Verbin wrote: > > > > Here is my current patch, it works for OpenMP->MIC, but obviously > > > > will not work

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-02-03 Thread Julian Brown
On Tue, 3 Feb 2015 14:28:44 +0300 Ilya Verbin wrote: > Hi Julian! > > On 27 Jan 14:07, Julian Brown wrote: > > On Mon, 26 Jan 2015 17:34:26 +0300 > > Ilya Verbin wrote: > > > Here is my current patch, it works for OpenMP->MIC, but obviously > > > will not work for PTX, since it requires symmetr

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-02-03 Thread Ilya Verbin
Hi Julian! On 27 Jan 14:07, Julian Brown wrote: > On Mon, 26 Jan 2015 17:34:26 +0300 > Ilya Verbin wrote: > > Here is my current patch, it works for OpenMP->MIC, but obviously > > will not work for PTX, since it requires symmetrical changes in the > > plugin. Could you please take a look, whethe

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-01-27 Thread Jack Howarth
Thomas, Any plans to fix https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64635 soon? On x86_64 darwin, the OpenACC merge resulted a huge number of failures in the libgomp test suite… === libgomp Summary === # of expected passes 10628 # of unexpected failures 724 # of unsupported tests 562 whic

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-01-27 Thread Julian Brown
On Mon, 26 Jan 2015 17:34:26 +0300 Ilya Verbin wrote: > Here is my current patch, it works for OpenMP->MIC, but obviously > will not work for PTX, since it requires symmetrical changes in the > plugin. Could you please take a look, whether it is possible to > support this new interface in PTX pl

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-01-27 Thread Julian Brown
On Mon, 26 Jan 2015 14:44:19 +0100 Thomas Schwinge wrote: > > On 17 Jan 02:16, Ilya Verbin wrote: > > > Unfortunately, it broke offloading from shared libraries (I mean > > > common libs with NEEDED entries, not dlopened). > > Sorry for that! > > > > Such things are not covered by the > > > tes

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-01-26 Thread Ilya Verbin
On 26 Jan 14:44, Thomas Schwinge wrote: > On 17 Jan 02:16, Ilya Verbin wrote: > > Such things are not covered by the > > testsuite, that's why you missed this issue. Here is a simple testcase: > >

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-01-26 Thread Thomas Schwinge
Hi! Sorry for the late answer -- I've been on sick leave, and just now returning to work. Julian, would you please have a look at the following issues? > > > In r219682, I have committed to trunk our current set of OpenACC changes, > > > which we had prepared on gomp-4_0-branch. Thanks to every

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-01-23 Thread Jakub Jelinek
On Fri, Jan 23, 2015 at 08:20:53PM +0300, Ilya Verbin wrote: > On 17 Jan 02:16, Ilya Verbin wrote: > > Hi! > > > > Unfortunately, it broke offloading from shared libraries (I mean common libs > > with NEEDED entries, not dlopened). Such things are not covered by the > > testsuite, that's why you

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-01-23 Thread Ilya Verbin
On 17 Jan 02:16, Ilya Verbin wrote: > Hi! > > Unfortunately, it broke offloading from shared libraries (I mean common libs > with NEEDED entries, not dlopened). Such things are not covered by the > testsuite, that's why you missed this issue. Here is a simple testcase: > ... > So, you don't ass

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-01-16 Thread Ilya Verbin
Hi! On 15 Jan 21:20, Thomas Schwinge wrote: > In r219682, I have committed to trunk our current set of OpenACC changes, > which we had prepared on gomp-4_0-branch. Thanks to everyone who has > been contributing! Unfortunately, it broke offloading from shared libraries (I mean common libs with NE

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-01-16 Thread Andreas Schwab
FAIL: c-c++-common/goacc/acc_on_device-2-off.c -std=c++98 scan-rtl-dump-times expand "(call [^n]*"acc_on_device" 1 FAIL: c-c++-common/goacc/acc_on_device-2-off.c -std=c++11 scan-rtl-dump-times expand "(call [^n]*"acc_on_device" 1 FAIL: c-c++-common/goacc/acc_on_device-

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-01-16 Thread Thomas Schwinge
Hi Gerald! On Fri, 16 Jan 2015 13:32:10 +0100 (CET), Gerald Pfeifer wrote: > On Thursday 2015-01-15 21:20, Thomas Schwinge wrote: > > In r219682, I have committed to trunk our current set of OpenACC changes, > > which we had prepared on gomp-4_0-branch. Thanks to everyone who has > > been contr

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-01-16 Thread David Malcolm
On Fri, 2015-01-16 at 15:39 +0100, Jakub Jelinek wrote: > On Thu, Jan 15, 2015 at 09:20:07PM +0100, Thomas Schwinge wrote: > > * builtin-types.def (BT_FN_VOID_INT_INT_VAR) > > (BT_FN_VOID_INT_PTR_SIZE_PTR_PTR_PTR_INT_INT_VAR) > > > > (BT_FN_VOID_INT_OMPFN_PTR_SI

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-01-16 Thread Jakub Jelinek
On Thu, Jan 15, 2015 at 09:20:07PM +0100, Thomas Schwinge wrote: > * builtin-types.def (BT_FN_VOID_INT_INT_VAR) > (BT_FN_VOID_INT_PTR_SIZE_PTR_PTR_PTR_INT_INT_VAR) > (BT_FN_VOID_INT_OMPFN_PTR_SIZE_PTR_PTR_PTR_INT_INT_INT_INT_INT_VAR): > New function types. This broke bootst

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-01-16 Thread Gerald Pfeifer
Once I work around the previous failure, I quickly get another one on FreeBSD 8.4/amd64: /scratch/tmp/gerald/gcc-HEAD/libgomp/target.c:67:12: error: \xe2\x80\x98num_devices\xe2\x80\x99 defined but not used [-Werror=unused-variable] static int num_devices; ^ This one did not require

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-01-16 Thread Gerald Pfeifer
Hi Thomas, On Thursday 2015-01-15 21:20, Thomas Schwinge wrote: > In r219682, I have committed to trunk our current set of OpenACC changes, > which we had prepared on gomp-4_0-branch. Thanks to everyone who has > been contributing! this breaks bootstrap on FreeBSD 8/amd64 from what I can tell:

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-01-16 Thread Jakub Jelinek
On Fri, Jan 16, 2015 at 11:46:35AM +0100, Uros Bizjak wrote: > On Fri, Jan 16, 2015 at 11:39 AM, Uros Bizjak wrote: > > Hello! > > > >> In r219682, I have committed to trunk our current set of OpenACC changes, > >> which we had prepared on gomp-4_0-branch. Thanks to everyone who has > >> been con

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-01-16 Thread Uros Bizjak
On Fri, Jan 16, 2015 at 11:39 AM, Uros Bizjak wrote: > Hello! > >> In r219682, I have committed to trunk our current set of OpenACC changes, >> which we had prepared on gomp-4_0-branch. Thanks to everyone who has >> been contributing! > > This patch breaks bootstrap on alpha-linux-gnu: > "target

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-01-16 Thread Uros Bizjak
Hello! > In r219682, I have committed to trunk our current set of OpenACC changes, > which we had prepared on gomp-4_0-branch. Thanks to everyone who has > been contributing! This patch breaks bootstrap on alpha-linux-gnu: /space/homedirs/uros/gcc-build/./gcc/xgcc -B/space/homedirs/uros/gcc-bui

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-01-15 Thread Tobias Burnus
Hi Thomas, thanks to you and all others involved for the OpenACC merge. Attached is a patch which converts for Fortran '%s' into %qs, as mentioned to before. (It wasn't possible when the original patch was reviewed as the common diagnostic patches came later.) Committed as Rev. 219694. On

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-01-15 Thread Jeff Law
On 01/15/15 13:20, Thomas Schwinge wrote: Hi! In r219682, I have committed to trunk our current set of OpenACC changes, which we had prepared on gomp-4_0-branch. Thanks to everyone who has been contributing! Note that this is an experimental feature, incomplete, and subject to change in future