Re: Make tests less istreambuf_iterator implementation dependent

2017-10-04 Thread Jonathan Wakely
On 04/10/17 18:21 +0200, François Dumont wrote: On 03/10/2017 16:20, Jonathan Wakely wrote: Doesn't the modified test PASS anyway, even without changing how _M_c is used? No it doesn't because the first check for eof capture the 'a' char which is never reseted so after string construction it

Re: Make tests less istreambuf_iterator implementation dependent

2017-10-04 Thread François Dumont
On 03/10/2017 16:20, Jonathan Wakely wrote: On 02/10/17 07:43 +0200, François Dumont wrote: On 28/09/2017 23:56, Jonathan Wakely wrote: On 28/09/17 21:59 +0200, François Dumont wrote: The current istreambuf_iterator implementation capture the current streambuf state each time it is tested fo

Re: Make tests less istreambuf_iterator implementation dependent

2017-10-03 Thread Jonathan Wakely
On 02/10/17 07:43 +0200, François Dumont wrote: On 28/09/2017 23:56, Jonathan Wakely wrote: On 28/09/17 21:59 +0200, François Dumont wrote: The current istreambuf_iterator implementation capture the current streambuf state each time it is tested for eof or evaluated. This is why I considered

Re: Make tests less istreambuf_iterator implementation dependent

2017-10-01 Thread François Dumont
On 28/09/2017 23:56, Jonathan Wakely wrote: On 28/09/17 21:59 +0200, François Dumont wrote: The current istreambuf_iterator implementation capture the current streambuf state each time it is tested for eof or evaluated. This is why I considered those tests as fragile. Yes, and I think that'

Re: Make tests less istreambuf_iterator implementation dependent

2017-09-28 Thread Jonathan Wakely
On 28/09/17 21:59 +0200, François Dumont wrote: On 28/09/2017 14:12, Jonathan Wakely wrote: On 27/09/17 22:16 +0200, François Dumont wrote: Hi     I just committed attached patch as trivial.     Those tests were highly istreambuf_iterator implementation, it is the result of the call to money

Re: Make tests less istreambuf_iterator implementation dependent

2017-09-28 Thread François Dumont
On 28/09/2017 14:12, Jonathan Wakely wrote: On 27/09/17 22:16 +0200, François Dumont wrote: Hi     I just committed attached patch as trivial.     Those tests were highly istreambuf_iterator implementation, it is the result of the call to money_get<>::get which is pointing immediately beyond

Re: Make tests less istreambuf_iterator implementation dependent

2017-09-28 Thread Jonathan Wakely
On 27/09/17 22:16 +0200, François Dumont wrote: Hi     I just committed attached patch as trivial.     Those tests were highly istreambuf_iterator implementation, it is the result of the call to money_get<>::get which is pointing immediately beyond the last character recognized to quote Stand